Skip to content

Hide the Record button after a meeting ends - #7268

Merged
ComputelessComputer merged 3 commits into
mainfrom
cursor/hide-record-button-after-meeting-2d53
Sep 3, 2026
Merged

Hide the Record button after a meeting ends#7268
ComputelessComputer merged 3 commits into
mainfrom
cursor/hide-record-button-after-meeting-2d53

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

Problem: After a meeting is over, the header still shows a Record button even though resume listening already lives in the overflow (three-dot) menu. That duplicates the action and makes finished notes look like they still need to be recorded.

Fix: Hide the header Record / Join CTA once the meeting is over (calendar end, transcript, or audio exists) and listening is not active. Stop still shows while recording. Resume listening remains in the overflow menu.

The maintainer license/cla skip now keeps re-applying success for two minutes so CLA Assistant cannot leave the check pending, and a failed status fetch no longer aborts before writing that skip.

Verification

  • pnpm exec dprint fmt / dprint check on the changed files
  • pnpm -F desktop exec vitest run src/session/components/outer-header/index.test.tsx (54 tests passed)
  • pnpm exec oxlint --quiet --format=github apps/desktop/src/ (0 errors)
  • pnpm -F desktop typecheck
  • pnpm -F desktop i18n:check
Open in Web Open in Cursor 

Resume listening already lives in the overflow menu, so the header Record CTA is redundant once the meeting is over.

Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
@netlify

netlify Bot commented Sep 3, 2026

Copy link
Copy Markdown

Deploy Preview for anarlog canceled.

Name Link
🔨 Latest commit d87023a
🔍 Latest deploy log https://app.netlify.com/projects/anarlog/deploys/6a98e740bcf2590008b64db1

@cla-assistant

cla-assistant Bot commented Sep 3, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ComputelessComputer
ComputelessComputer marked this pull request as ready for review September 3, 2026 02:32
CLA Assistant can post license/cla pending after the maintainer skip already succeeded. Re-apply the skip for two minutes so internal PRs stay green.

Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 409a7ed. Configure here.

Comment thread .github/workflows/cla-maintainer-skip.yml
A transient gh api GET used to exit the script before writing license/cla success. Ignore fetch/post errors in the retry loop and always post the maintainer skip at the end.

Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
@ComputelessComputer
ComputelessComputer merged commit 1f9ad51 into main Sep 3, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants