Hide the Record button after a meeting ends - #7268
Merged
ComputelessComputer merged 3 commits intoSep 3, 2026
Merged
Conversation
Resume listening already lives in the overflow menu, so the header Record CTA is redundant once the meeting is over. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
✅ Deploy Preview for anarlog canceled.
|
|
|
ComputelessComputer
marked this pull request as ready for review
September 3, 2026 02:32
CLA Assistant can post license/cla pending after the maintainer skip already succeeded. Re-apply the skip for two minutes so internal PRs stay green. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 409a7ed. Configure here.
A transient gh api GET used to exit the script before writing license/cla success. Ignore fetch/post errors in the retry loop and always post the maintainer skip at the end. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Problem: After a meeting is over, the header still shows a Record button even though resume listening already lives in the overflow (three-dot) menu. That duplicates the action and makes finished notes look like they still need to be recorded.
Fix: Hide the header Record / Join CTA once the meeting is over (calendar end, transcript, or audio exists) and listening is not active. Stop still shows while recording. Resume listening remains in the overflow menu.
The maintainer
license/claskip now keeps re-applying success for two minutes so CLA Assistant cannot leave the check pending, and a failed status fetch no longer aborts before writing that skip.Verification
pnpm exec dprint fmt/dprint checkon the changed filespnpm -F desktop exec vitest run src/session/components/outer-header/index.test.tsx(54 tests passed)pnpm exec oxlint --quiet --format=github apps/desktop/src/(0 errors)pnpm -F desktop typecheckpnpm -F desktop i18n:check