Protect recordings from empty captures and stale deletions - #7444
Merged
Conversation
✅ Deploy Preview for anarlog canceled.
|
ComputelessComputer
force-pushed
the
fix/multi-device-capture-safety
branch
from
September 7, 2026 15:02
f2a9c88 to
3f047a1
Compare
Discard only confirmed empty scheduled desktop audio. Preserve unseen recording and note content across synced deletions while keeping intentional deletion and mobile recording behavior intact.
Handle SQLite boolean attachment flags during safe automatic cleanup and accept both string and structured attachment versions when reconciling synced deletions.
ComputelessComputer
force-pushed
the
fix/multi-device-capture-safety
branch
from
September 7, 2026 15:47
3f047a1 to
4296ffa
Compare
Restore unseen local transcripts, notes, and audio immediately while preserving deletion observations for later sync. Keep empty writes and intentional deletions unchanged, with regression coverage for offline writes.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4f1bdbf. Configure here.
cursor Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
main's #7444 added automatic, preserveExistingAudio and initialTitle to CaptureLifecycleMarker. The shell writes them for its manual captures (false / true / the session title at start), parses them from the web view's markers and keeps them through recovery, so both shells read each other's markers unchanged. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
cursor Bot
pushed a commit
that referenced
this pull request
Sep 8, 2026
main's #7444 added automatic, preserveExistingAudio and initialTitle to CaptureLifecycleMarker. The shell writes them for its manual captures (false / true / the session title at start), parses them from the web view's markers and keeps them through recovery, so both shells read each other's markers unchanged. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
cursor Bot
pushed a commit
that referenced
this pull request
Sep 8, 2026
main's #7444 added automatic, preserveExistingAudio and initialTitle to CaptureLifecycleMarker. The shell writes them for its manual captures (false / true / the session title at start), parses them from the web view's markers and keeps them through recovery, so both shells read each other's markers unchanged. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
cursor Bot
pushed a commit
that referenced
this pull request
Sep 8, 2026
main's #7444 added automatic, preserveExistingAudio and initialTitle to CaptureLifecycleMarker. The shell writes them for its manual captures (false / true / the session title at start), parses them from the web view's markers and keeps them through recovery, so both shells read each other's markers unchanged. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Discard only confirmed empty scheduled desktop audio. Preserve unseen recording and note content across synced deletions while keeping intentional deletion and mobile recording behavior intact.
Note
High Risk
Changes E2EE session deletion and restoration semantics plus automatic local audio removal; incorrect guards or reconciliation could delete valid recordings or resurrect or drop synced session data.
Overview
Scheduled desktop captures can now be dropped when they turn out to be empty: auto-starts are tagged as
automatic, lifecycle markers remember pre-recording audio state and the initial title, and on stop the app runsdiscardEmptyAutomaticCapturebefore cataloging audio or batch work. That path uses a newaudio_has_speechfs-sync command (VAD infs-sync-core) and only deletes local audio when speech is confidently absent and the note is still unchanged, empty, and unattached; manual starts stay manual even if a scheduled waiter exists.Synced session deletions gain observation-based reconciliation so notes are not lost to tombstones the deleter never saw. Migrations add
content_versionon documents/transcripts,deletion_contexton sessions, asession_content_observationsview, local restore triggers when real content arrives offline, andreconcile_session_deletionduring E2EE replica apply. Intentional deletes still stick once observed content matches; empty/metadata-only writes do not resurrect deleted sessions.Reviewed by Cursor Bugbot for commit 4f1bdbf. Bugbot is set up for automated code reviews on this repo. Configure here.