Validate Custom STT without requiring an OpenAI model catalog - #7446
Merged
Conversation
Pass provider type through desktop saving and availability checks. Preserve URL and key validation plus Custom LLM authentication, with regression coverage.
✅ Deploy Preview for anarlog canceled.
|
ComputelessComputer
deleted the
fix/custom-stt-credential-verification
branch
September 8, 2026 02:05
cursor Bot
pushed a commit
that referenced
this pull request
Sep 8, 2026
Main's #7446 makes `verifyProviderCredentials` return early for a Custom STT credential once the static checks pass, since a Deepgram-compatible listen server need not expose a model catalog or a probe endpoint. The shell's verification takes the provider type from both callers (the save path and the availability gate) and does the same; the LLM side still probes. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
cursor Bot
pushed a commit
that referenced
this pull request
Sep 8, 2026
Main's #7446 makes `verifyProviderCredentials` return early for a Custom STT credential once the static checks pass, since a Deepgram-compatible listen server need not expose a model catalog or a probe endpoint. The shell's verification takes the provider type from both callers (the save path and the availability gate) and does the same; the LLM side still probes. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass provider type through desktop saving and availability checks. Preserve URL and key validation plus Custom LLM authentication, with regression coverage.
Note
Medium Risk
Changes AI provider credential validation and save/availability flows, but the behavior change is scoped to Custom STT with tests; other callers that omit
typekeep prior verification behavior.Overview
Custom STT (
stt+custom) can be saved and marked available after URL and API key checks only—no OpenAI-style/modelsor control-key probe, since many listen servers never expose a catalog.The desktop app now passes
type(stt|llm) intoverifyProviderCredentialsfrom provider save (useSetAiProvider) and availability (useProviderAvailability). Custom LLM and other providers keep the existing network verification path.Regression tests cover package validation, desktop save/availability, and the split between Custom STT (no fetch) vs Custom LLM (still probes and can fail on unsupported endpoints).
Reviewed by Cursor Bugbot for commit 67cfe03. Bugbot is set up for automated code reviews on this repo. Configure here.