Conversation
Co-Authored-By: unknown <>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote canceled.
|
Co-Authored-By: unknown <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply cargo clippy auto-fixes
Summary
Ran
cargo clippy --fixacross the workspace and applied the resulting suggestions. Changes:Cargo.toml: Addedplugins/cli2to workspaceexcludelist (it has noCargo.toml, onlynode_modules, and was breaking workspace resolution via theplugins/*glob).crates/analytics/src/posthog.rs: Removed redundant.to_string()on a&stralready satisfying the expected type.crates/tiptap/src/from_ast.rs,plugins/fs-db/src/migrations/...,plugins/fs-db/src/version/macro.rs: Collapsed nestedif/if letblocks into let-chains (clippy::collapsible_if/clippy::collapsible_match). Also elided unnecessary explicit lifetime parameters where Rust can infer them.Note: Some workspace crates depending on
libspa/pipewire could not be compiled on the build environment due to a system library version mismatch, so their clippy output was not captured.Review & Testing Checklist for Human
from_ast.rs: The collapsedif c == '\\' && let Some(&next) = chars.peek() && is_markdown_escapable(next)must behave identically to the original nested version — confirmresult.push(c)still executes for all non-matching cases.plugins/cli2exclude: Confirm this directory is intentionally JS-only and should be excluded from the Cargo workspace.Notes