Skip to content

Apply cargo clippy fixes#3976

Merged
yujonglee merged 2 commits intomainfrom
devin/1771113775-clippy-fixes
Feb 15, 2026
Merged

Apply cargo clippy fixes#3976
yujonglee merged 2 commits intomainfrom
devin/1771113775-clippy-fixes

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Feb 15, 2026

Apply cargo clippy auto-fixes

Summary

Ran cargo clippy --fix across the workspace and applied the resulting suggestions. Changes:

  • Cargo.toml: Added plugins/cli2 to workspace exclude list (it has no Cargo.toml, only node_modules, and was breaking workspace resolution via the plugins/* glob).
  • crates/analytics/src/posthog.rs: Removed redundant .to_string() on a &str already satisfying the expected type.
  • crates/tiptap/src/from_ast.rs, plugins/fs-db/src/migrations/..., plugins/fs-db/src/version/macro.rs: Collapsed nested if/if let blocks into let-chains (clippy::collapsible_if / clippy::collapsible_match). Also elided unnecessary explicit lifetime parameters where Rust can infer them.

Note: Some workspace crates depending on libspa/pipewire could not be compiled on the build environment due to a system library version mismatch, so their clippy output was not captured.

Review & Testing Checklist for Human

  • Verify let-chain semantics in from_ast.rs: The collapsed if c == '\\' && let Some(&next) = chars.peek() && is_markdown_escapable(next) must behave identically to the original nested version — confirm result.push(c) still executes for all non-matching cases.
  • Confirm project is okay with let-chains syntax: Requires Rust 1.87+. The toolchain file pins 1.92.0, but verify this won't break any other build targets or CI.
  • plugins/cli2 exclude: Confirm this directory is intentionally JS-only and should be excluded from the Cargo workspace.

Notes


Open with Devin

Co-Authored-By: unknown <>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Feb 15, 2026

Deploy Preview for hyprnote-storybook ready!

Name Link
🔨 Latest commit 40aa57a
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/699110550b73c0000820f25e
😎 Deploy Preview https://deploy-preview-3976--hyprnote-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 15, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit 40aa57a
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/6991105522406400086d5a8a

Copy link
Contributor Author

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 0 potential issues.

Open in Devin Review

@yujonglee yujonglee merged commit d6f3f12 into main Feb 15, 2026
12 of 13 checks passed
@yujonglee yujonglee deleted the devin/1771113775-clippy-fixes branch February 15, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant