Conversation
…eOptions Prepare crates/cactus for upstream cactus-compute/cactus#396 which adds custom vocabulary / hotword biasing for transcription. - Add custom_vocabulary (Vec<String>) and vocabulary_boost (f32) fields to TranscribeOptions, serialized into options_json for the C FFI. - Wire ListenParams.keywords through to custom_vocabulary in both the streaming and batch transcription paths in transcribe-cactus. Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(cactus): add custom_vocabulary and vocabulary_boost to TranscribeOptions
Summary
Prepares
crates/cactusfor upstream cactus-compute/cactus#396, which will add custom vocabulary / hotword biasing to the transcription APIs.custom_vocabulary: Option<Vec<String>>andvocabulary_boost: Option<f32>toTranscribeOptions. Both are serde-skipped whenNone, so they're invisible to the current C FFI until upstream ships support.ListenParams.keywords→TranscribeOptions.custom_vocabularyin both the streaming and batch transcription paths intranscribe-cactus.vocabulary_boostis intentionally left unwired — there's no source for it inListenParamstoday; it's there so callers can set it once upstream supports it.Review & Testing Checklist for Human
options_json. If it errors on unrecognized fields, passingcustom_vocabularywhenkeywordsis non-empty would break transcription. (Most likely safe sinceskip_serializing_ifkeeps it out whenNone, and no current caller setskeywordsfor the cactus path — but worth confirming.)custom_vocabulary,vocabulary_boost) match the upstream issue's proposed JSON schema. A mismatch would require a rename later.keywordsinListenParamsand verify transcription still succeeds without errors (i.e., the extra JSON key doesn't cause a C-side parse failure).Notes
cactus-sysC++ build requires ARM architecture flags not available on x86. Changes are minimal struct additions + field wiring.