Optimize skunk.gemspec: Streamlined gem specification and cleaned metadata and file handling. #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adata and file handling. I optimized the skunk.gemspec by simplifying the required_ruby_version to a string format for clarity, streamlined the metadata handling to only include necessary sections, and improved the file inclusion process for efficiency. I also clarified comments for better understanding. These changes enhance readability, reduce redundancy, and ensure the file is easier to maintain and extend in the future.
JuanVqz
reviewed
Dec 20, 2024
| spec.required_ruby_version = ">= 2.4.0" | ||
|
|
||
| # Prevent pushing this gem to RubyGems.org unless specified | ||
| spec.metadata["allowed_push_host"] = "https://www.rubygems.org" if spec.respond_to?(:metadata) |
There was a problem hiding this comment.
Hi @infyomer, Thanks for the contribution, however, I'm not sure this is the right change. If you keep the if for this line, why didn't you add it for the next 3 metadata lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I optimized the skunk.gemspec by simplifying the required_ruby_version to a string format for clarity, streamlined the metadata handling to only include necessary sections, and improved the file inclusion process for efficiency. I also clarified comments for better understanding. These changes enhance readability, reduce redundancy, and ensure the file is easier to maintain and extend in the future.