Clean handling boundary conditions (no derived types) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbovy
force-pushed
the
clean-bc-no-derived-type
branch
from
932b0d9 to
28e117b
Compare
|
I did inspect all Fortran examples and Jupyter notebooks in fastscape-demo (with some updates that will be merged after this PR: fastscape-lem/fastscape#18 and fastscape-lem/fastscape-demo#4). It looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a - rather unfortunate - alternative to #32 that is not using Fortran derived types.
It doesn't improve the signatures of some of the functions, but at least this is compatible with
f2py.Also fixes #31.
@jeanbraun if you have time could you have a look before I merge this? I inspected the Fortran
Fanexample and the Python notebook example, and they look both good. I didn't inspect the results further.