Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Features about Number.prototype.toLocaleString() for IE11 in win7 and 8, a lot of related new definitions (reopened again) #57

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Clayblockunova
Copy link
Contributor

Sorry for create a PR about that the third time. What should I do about IE11 subversions?

@Clayblockunova Clayblockunova changed the title update definitionsNew Features about Number.prototype.toLocaleString() for IE11 in win7 and 8, a lot of related new definitions (reopened again) New Features about Number.prototype.toLocaleString() for IE11 in win7 and 8, a lot of related new definitions (reopened again) Oct 16, 2024
@Clayblockunova
Copy link
Contributor Author

what should I do now? does your work finished?

@Clayblockunova
Copy link
Contributor Author

Clayblockunova commented Oct 19, 2024

should I rearrange those IE11 related features?

@Clayblockunova
Copy link
Contributor Author

what happened to the project?

@fasttime
Copy link
Owner

I'm sorry, I still need some time to look into this, as I don't have fresh Windows 7 and Windows 8 VMs for testing.

@Clayblockunova
Copy link
Contributor Author

I'm sorry, I still need some time to look into this, as I don't have fresh Windows 7 and Windows 8 VMs for testing.

is getting that very hard in Europe?

@Clayblockunova
Copy link
Contributor Author

when will your work finished?

useLocaleNumeralDefinition('ا', '"ar"', Infinity, 2, LOCALE_NUMERALS_IE11_WIN7_8);
useLocaleNumeralDefinition('ن', '"ar"', Infinity, 4, LOCALE_NUMERALS_IE11_WIN7_8);
useLocaleNumeralDefinition('ه', '"ar"', Infinity, 5, LOCALE_NUMERALS_IE11_WIN7_8);
useLocaleNumeralDefinition('ﺓ', '"ar"', Infinity, 8, LOCALE_NUMERALS_IE11_WIN7_8);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a different character. Did you mean this one?

Suggested change
useLocaleNumeralDefinition('', '"ar"', Infinity, 8, LOCALE_NUMERALS_IE11_WIN7_8);
useLocaleNumeralDefinition('ة', '"ar"', Infinity, 8, LOCALE_NUMERALS_IE11_WIN7_8);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

src/lib/definitions.js Show resolved Hide resolved
@Clayblockunova
Copy link
Contributor Author

what should I do now?

Copy link
Owner

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I still need to test this on Windows 7.

useLocaleNumeralDefinition('数', '"ja"', NaN, 6, LOCALE_NUMERALS_IE11_WIN7_8);
useLocaleNumeralDefinition('値', '"ja"', NaN, 7, LOCALE_NUMERALS_IE11_WIN7_8);
useLocaleNumeralDefinition('ė', '"lt"', Infinity, 7, LOCALE_NUMERALS_IE11_WIN7);
useLocaleNumeralDefinition('ī', '"lv"', Infinity, 6, LOCALE_NUMERALS_IE11_WIN7_8);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting "∞" for Infinity.toLocaleString("lv") on Windows 8 with the latest updates.

@Clayblockunova
Copy link
Contributor Author

It's December now. when will you finish current work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants