Change to check on createEvent instead of attachEvent #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion uses createEvent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to check on createEvent instead of attachEvent in firelistener, since the function actually uses createEvent.
We had a problem in IE8 which surprisingly used the firelistener function for modern browsers. In other words, the W3C_MODEL was true. That was because we have a polyfill for attachEvent. But we do not have a polyfill for createEvent, which is actually the method in use in firelistener.
Is it a bug or is it another reason why you check for attachEvent, but uses the createEvent?
The pull request assumes it is a bug and therefore checks for createEvent instead.
Best regards,
Maiken