feat: add client reload on config change #4256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature is not currently in the plan due to some concerns and it is not very perfect. For now, you can reload the configuration through the reload API after updating the configuration file. |
|
PRs go stale after 21d of inactivity. Stale PRs rot after an additional 7d of inactivity and eventually close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thid pull request proposed as part of the homework for the course "designing the architecture of software systems". The ability to configure client updates when configuration files are changed is implemented. "Watcher" was used instead of "fsnotify" due to problems with the compatibility of the second with macos