fix: validate effective chat picker readiness - #854
Open
itsJai42 wants to merge 1 commit into
Open
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{provider, model, baseUrl}identity.envandauth.jsoncredential probes for Remote and SSH connections while preserving missing-model validationlat.mdWhy
Chat already reran readiness when picker state changed, but IPC validated only the persisted global model. That produced
NO_ACTIVE_MODELfor valid session picks. Forwarding the picker identity exposes a second boundary: Remote and SSH credentials live on the other host, so Desktop cannot inferMISSING_API_KEYfrom local files.This supersedes #839, credits its picker-override approach, and incorporates the Remote/SSH refinement reported in #839 (comment).
Verification
mainwithNO_ACTIVE_MODEL,MISSING_API_KEY, and missing model-detection mismatchnpm run typecheck: passednpm run build: passedgit diff --check, andlat check: passedExisting baseline
Full
npm run lintremains nonzero because currentmainhas 9 errors in unchangedsrc/renderer/src/components/ProviderKeysSection.tsx. This PR adds no lint errors.