feat(office): derive activity from running Kanban cards#869
Open
ohjy1006kenneth wants to merge 2 commits into
Open
feat(office): derive activity from running Kanban cards#869ohjy1006kenneth wants to merge 2 commits into
ohjy1006kenneth wants to merge 2 commits into
Conversation
Contributor
Greptile SummaryThis PR derives Office activity from running Kanban cards. The main changes are:
Confidence Score: 5/5The latest changes appear safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "test(office): use generic profile fixtur..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workingstatus from profiles that ownrunningKanban cardsWhy
A persistent Hermes gateway being online does not mean that its profile is actively working. Conversely, dispatcher-launched Kanban workers can be processing a card without owning a standalone gateway process. This can make Office status misleading, especially in SSH mode when multiple profiles share a Kanban board.
Office now treats a profile as
Workingwhen the selected profile's Kanban board contains at least onerunningcard assigned to that profile. Other profiles remainIdle. Gateway state still controls chat availability and remains the compatibility fallback for connection modes where Kanban cannot be queried.Verification
npx vitest run src/renderer/src/screens/Office/Office.statusPolling.test.tsx src/renderer/src/screens/Office/office3d/agents.test.ts— 8 passednpx vitest run --maxWorkers=1— 173 files passed; 1,827 tests passed; 3 skippednpm run typecheck— passednpm run lint— passed with 0 errors (9 pre-existing warnings outside this change)npm run build— passedgit diff --cached --check— passedLive acceptance check
Verified against a remote Hermes Agent host where multiple profiles shared one Kanban board and exactly one profile owned a
runningcard:WorkingIdle, even when their gateways were onlineThe status refresh uses the existing SSH-capable
kanbanListTasksIPC path; no new remote command or privilege surface is introduced.