Skip to content

mingw: Add platform checking of GoDocBrowser for Cygwin on windows #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

mingw: Add platform checking of GoDocBrowser for Cygwin on windows #3611

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8c07f6f
update
rwxguo Dec 14, 2023
ba8f431
update
rwxguo Dec 15, 2023
a3b82af
update
rwxguo Dec 15, 2023
a842589
update
rwxguo Dec 15, 2023
bb17f91
update
rwxguo Dec 15, 2023
e6a48de
add cygwin detection (include cygwin, msys2 and gitbash)
rwxguo Dec 24, 2023
2e1c93c
removed unmae checks and win32 checks
rwxguo Dec 24, 2023
f14d170
use cygstart instead of start for cygwin rather than msys2 and gitbash
rwxguo Dec 25, 2023
ac13737
update
rwxguo Dec 25, 2023
2060e8f
update
rwxguo Dec 25, 2023
80ca0ee
update
rwxguo Dec 25, 2023
554e2d5
Merge branch 'fatih:master' into doc-browser-gitbash
rwxguo Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion autoload/go/config.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ function! go#config#SnippetEngine() abort
endfunction

function! go#config#PlayBrowserCommand() abort
if go#util#IsWin()
if go#util#IsWin() || go#util#IsCygwin()
let go_play_browser_command = '!start rundll32 url.dll,FileProtocolHandler %URL%'
elseif go#util#IsMac()
let go_play_browser_command = 'open %URL%'
Expand Down
12 changes: 12 additions & 0 deletions autoload/go/util.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,17 @@ function! go#util#IsMac() abort
\ go#util#Exec(['uname'])[0] =~? '^darwin'
endfunction

" IsCygwin returns 1 if current OS is Cygwin/MSYS2/GitBash, 0 otherwise
function! go#util#IsCygwin()
return !has('win32') &&
\ has('win32unix') &&
\ (
\ system('uname') =~ 'CYGWIN' ||
\ system('uname') =~ 'MINGW' ||
\ system('uname') =~ 'MSYS'
\ )
endfunction

" Checks if using:
" 1) Windows system,
" 2) And has cygpath executable,
Expand Down Expand Up @@ -529,6 +540,7 @@ function! go#util#OpenBrowser(url) abort
if l:cmd =~ '^!'
let l:cmd = substitute(l:cmd, '%URL%', '\=escape(shellescape(a:url), "#")', 'g')
silent! exec l:cmd
redraw!
elseif cmd =~ '^:[A-Z]'
let l:cmd = substitute(l:cmd, '%URL%', '\=escape(a:url,"#")', 'g')
exec l:cmd
Expand Down