-
-
Notifications
You must be signed in to change notification settings - Fork 344
Immich album plugin #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Immich album plugin #321
Conversation
|
This feature was already rejected in #211. Although, I think it is a good new plugin. Immich is by far the biggest Open-Source Photo Management solution, and it makes totally sense to provide a plugin for it. Maybe, it is possible to make this a bit agnostic and make it easily extendible for other photo platforms, somehow like the weather plugin where you can switch between OpenMeteo and OpenWeatherMap. |
move Immich requests to own class
add random selection
improve class add image alignment filtering
fix requirements
|
Immich being my primary use case for a digital frame, I hope this can be merged. |
| return template_params | ||
|
|
||
| def generate_image(self, settings, device_config): | ||
| random = settings.get("randomize", False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesnt seem to be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure how random vs not random should work. I think if we get the assets by their natural order (default is by time) we have to remember which ones we displayed and remove them from the list the next time the plugin is called. So we avoid displaying the first element all the time.
|
Thanks for the comments, will have a look! |
# Conflicts: # install/requirements-dev.txt # install/requirements.txt # src/utils/image_utils.py
add PR comments
loads images from an album on an Immich server
support for heif image format added
still missing: image settings via the UI (padding, fit to frame, etc)