-
-
Notifications
You must be signed in to change notification settings - Fork 343
Calendar rendering tweaks #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
deftdawg
commented
Nov 11, 2025
- use 'block' event types for all calendar views
- force word-wrapping of event titles in calendar views
- dynamically size minimum eventbox height based on selected font_scale
|
Not sure I agree with this change, if there are a few long event titles it takes up the whole space (see test image below). I'm open to enabling this as an option in the UI with the default being the existing behavior since this was requested in #346.
|
|
Comment is fair, I'll rework it to make it an option... In my case, the stock rendering behavior (on a portrait orientation) results in entries that look like "9:00a Take V" - My wife, who won't use a phone calendar, will ask me what is that... 😆 |
04e018e to
e7282c9
Compare
|
TODO: I want to tweak events that handle multiple days... lakers games that span midnight make block rendering look bad, need to split those into 2 parts for daygrid/daygridMonth |
|
You may implement a solution for #335 so that the second part of the 2-day-spanning event is shown as a small bar only? |
I'm not really aiming to solve that with this PR. But I'll take a quick detour to see if I can figure out how to do blocks like "+2 before 8a" & "+1 after 10p"... for day/week views. |
|
spent way too much time on this @F2011 😅 ... There's a bug w/ split events that go over midnight (going to 5a) and the code is awful quality, so it needs to be rewritten (there were so many edge cases I hit, that made the code turn into a mess). But here are some screens of about the best we're likely going to get with this PR. |
|
I'm happy with it like this, still need to refactor and then I'll push it up. Here's what it looks like now (Text Wrap Test CalendarsPersonal + US Holidays, Canadian Holidays, NBA - LA Lakers, NBA - GS Warriors, NBA - San Antonio Spurs Day (9a - 8p)
Week (9a - 8p)
Multi-week (4 weeks)
EDIT: Weekend Shading |
|
I really like your solution of #335. Thanks a lot :) |
Yeah w/ Text Wrap… that option name fit the original scope, but we now have that, “X more” overlays and weekend shading… so I’m thinking to rename it to “Enhanced”, “Alt Rendering”, “Beta”… something more generic and the put a mouse over hint for what it enables. |
9b8051f to
a355cec
Compare
when enabled: - events render as blocks for better readability - dynamically size minimum eventbox height based on selected font_scale - when events start before or after the view period there are now badges that give an indication of when, what they are or how many more events - weekends are shaded 25% darker than weekdays - input validation endInterval - startInterval >= 1 - warning showModal message type for validation error Dynamic Start option (resolves fatihak#199) when enabled: - Calendar start time will automatically adjust to the earliest event of the day. Fix for FullCalendar sometimes converting en-dash into "â€"
f3d6c19 to
632bee6
Compare
|
Squashed commits into 1 and added "Dynamic Start" to resolve #199 Block Layout rendering option (resolves #335) when enabled:
Dynamic Start option (resolves #199) when enabled:
Fix for FullCalendar sometimes converting en-dash into "â€" |











