Skip to content

Conversation

@deftdawg
Copy link
Contributor

  • use 'block' event types for all calendar views
  • force word-wrapping of event titles in calendar views
  • dynamically size minimum eventbox height based on selected font_scale

@fatihak
Copy link
Owner

fatihak commented Nov 15, 2025

Not sure I agree with this change, if there are a few long event titles it takes up the whole space (see test image below). I'm open to enabling this as an option in the UI with the default being the existing behavior since this was requested in #346.

accd90af-c1fb-41e5-a03f-1102e3ede1d8

@deftdawg
Copy link
Contributor Author

deftdawg commented Nov 15, 2025

Comment is fair, I'll rework it to make it an option... In my case, the stock rendering behavior (on a portrait orientation) results in entries that look like "9:00a Take V" - My wife, who won't use a phone calendar, will ask me what is that... 😆

@deftdawg
Copy link
Contributor Author

"Text Wrap" option added that applies the changes when checked:
image

@deftdawg
Copy link
Contributor Author

TODO: I want to tweak events that handle multiple days... lakers games that span midnight make block rendering look bad, need to split those into 2 parts for daygrid/daygridMonth

@F2011
Copy link

F2011 commented Nov 16, 2025

You may implement a solution for #335 so that the second part of the 2-day-spanning event is shown as a small bar only?

@deftdawg
Copy link
Contributor Author

You may implement a solution for #335 so that the second part of the 2-day-spanning event is shown as a small bar only?

I'm not really aiming to solve that with this PR. But I'll take a quick detour to see if I can figure out how to do blocks like "+2 before 8a" & "+1 after 10p"... for day/week views.

@deftdawg deftdawg marked this pull request as draft November 17, 2025 22:34
@deftdawg
Copy link
Contributor Author

deftdawg commented Nov 18, 2025

spent way too much time on this @F2011 😅 ...

There's a bug w/ split events that go over midnight (going to 5a) and the code is awful quality, so it needs to be rewritten (there were so many edge cases I hit, that made the code turn into a mess). But here are some screens of about the best we're likely going to get with this PR.

imageimageimageimage

@deftdawg
Copy link
Contributor Author

deftdawg commented Nov 20, 2025

I'm happy with it like this, still need to refactor and then I'll push it up. Here's what it looks like now (Text Wrap on is new rendering tweaks; off is existing render behavior):

Test Calendars

Personal + US Holidays, Canadian Holidays, NBA - LA Lakers, NBA - GS Warriors, NBA - San Antonio Spurs

Day (9a - 8p)

Text Wrap off Text Wrap on
image image

Week (9a - 8p)

Text Wrap off Text Wrap on
image image

Multi-week (4 weeks)

Text Wrap off Text Wrap on
image image

EDIT: Weekend Shading

@F2011
Copy link

F2011 commented Nov 20, 2025

I really like your solution of #335. Thanks a lot :)
Am I right that the „X more“-indicators are only shown with text wrap activated?
May we introduce a separate toggle for this?

@deftdawg
Copy link
Contributor Author

Am I right that the „X more“-indicators are only shown with text wrap activated? May we introduce a separate toggle for this?

Yeah w/ Text Wrap… that option name fit the original scope, but we now have that, “X more” overlays and weekend shading… so I’m thinking to rename it to “Enhanced”, “Alt Rendering”, “Beta”… something more generic and the put a mouse over hint for what it enables.

@deftdawg deftdawg marked this pull request as ready for review November 24, 2025 06:16
when enabled:
- events render as blocks for better readability
- dynamically size minimum eventbox height based on selected font_scale
- when events start before or after the view period there are now badges that give an indication of when, what they are or how many more events
- weekends are shaded 25% darker than weekdays
- input validation endInterval - startInterval >= 1
- warning showModal message type for validation error

Dynamic Start option (resolves fatihak#199)

when enabled:
- Calendar start time will automatically adjust to the earliest event of the day.

Fix for FullCalendar sometimes converting en-dash into "â€"
@deftdawg
Copy link
Contributor Author

Squashed commits into 1 and added "Dynamic Start" to resolve #199

Block Layout rendering option (resolves #335)

when enabled:

  • events render as blocks for better readability
  • dynamically size minimum eventbox height based on selected font_scale
  • when events start before or after the view period there are now badges that give an indication of when, what they are or how many more events
  • weekends are shaded 25% darker than weekdays
  • input validation endInterval - startInterval >= 1
  • warning showModal message type for validation error

Dynamic Start option (resolves #199)

when enabled:

  • Calendar start time will automatically adjust to the earliest event of the day.

Fix for FullCalendar sometimes converting en-dash into "â€"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants