Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serial_comms.py #69

Open
wants to merge 1 commit into
base: mms
Choose a base branch
from

Conversation

havefunworkhard
Copy link

Seems like self.serial.read(1) in serial_comms.py returns bytes in Python 3.x.
But code expects strings and compares returned value with strings like RX_EOL_SEQ = '\r\n' or ''. The comparison result will always be False.
In this case SerialComms will never _handleLineRead and TimeoutException will be raised.

@alejandroMA
Copy link

I been waiting 3 moths for a pull request to be merge or rejected :(

@babca
Copy link

babca commented Aug 19, 2016

@foXes68 Let's make the project alive again.
I've merged all the fixes including yours here:
https://github.com/babca/python-gsmmodem

please check it out and do a pull request there if you found any bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants