Skip to content

fix: setup wizard crashes when skipping LLM provider #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abbudjoe merged 2 commits into from
Mar 24, 2026
Merged

fix: setup wizard crashes when skipping LLM provider #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7579e40
fix: setup wizard crashes when skipping LLM provider
abbudjoe Mar 24, 2026
4958f23
fix: skip model validation when no model/provider configured
abbudjoe Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions engine/crates/fx-cli/src/commands/setup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,12 +328,14 @@ impl SetupWizard {
}

async fn run_model_phase(&mut self) -> anyhow::Result<()> {
let Some(provider) = self.selected_provider.clone() else {
println!("Step 2: Model Selection");
println!(" ⏭ Skipped (no provider configured yet)");
println!();
return Ok(());
};
println!("Step 2: Model Selection");
println!(" Fetching available models...");
let provider = self
.selected_provider
.clone()
.context("provider not selected")?;
let models = self.available_models(&provider).await?;
print_models(&provider, &models);
println!(" (press Enter to skip)");
Expand Down Expand Up @@ -568,10 +570,10 @@ impl SetupWizard {
}

async fn validate_model_connection(&self) -> anyhow::Result<()> {
let model = self
.default_model
.as_deref()
.context("model not selected")?;
let Some(model) = self.default_model.as_deref() else {
println!(" ⏭ Skipped (no model configured yet)");
return Ok(());
};
let mut router =
build_router(&self.auth_manager).map_err(|error| anyhow!(error.to_string()))?;
router
Expand Down
Loading