Skip to content

assignment 2#2

Open
faykisteroff wants to merge 2 commits intomainfrom
assignment-2
Open

assignment 2#2
faykisteroff wants to merge 2 commits intomainfrom
assignment-2

Conversation

@faykisteroff
Copy link
Owner

@faykisteroff faykisteroff commented Aug 31, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change Requested

You're making solid progress!

Part 1: The assignment is asking you to print all lines from the first file. Right now, your code opens the CSV file at all_paths[0], but then loops through all_paths. Each time the loop runs, it reads the next line from the first file — so you end up printing the first 12 lines of the first file (since there are 12 files in all_paths). Instead of looping through all_paths, you should loop through the variable returned by readlines() or readline() to print all lines from the first file.

Part 3: The function should take a single CSV file path, not a list — so no loop is needed. Also, be sure to call patient_summary on the input parameter, not all_paths[0].

Quick reminder: please remember to include a brief PR description in future submissions to summarize your pull request.

I have edited the comments to include more details. Please feel free to let me know if further clarification is needed. ☺️

@faykisteroff
Copy link
Owner Author

Made requested revisions to assignment 2 for parts 1 and 3.

Edited the loop in part 1 and removed the loop in part 3.

Copy link

@xindizhang xindizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! No further changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants