Skip to content
This repository has been archived by the owner on Apr 1, 2022. It is now read-only.

Add Gujarati language translation! #112

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

ashish11chawda
Copy link
Contributor

@ashish11chawda ashish11chawda commented Aug 14, 2020

Is your pull request related to a problem? Please describe

It adds the Gujarati Language support as per #57

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.
  • I have added the label enhancement to my pull request.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2020
@ashish11chawda
Copy link
Contributor Author

@elinguiuriel @aboullaite Can you please review this PR?

@aboullaite aboullaite added the help wanted Extra attention is needed label Aug 17, 2020
@aboullaite
Copy link
Contributor

Thank you @pixan198 for taking tame adding support for Gujarati. Unfortunately neither me nor @elinguiuriel speak Gujarati! We're waiting for community help on that one. would you recommend someone that can help ?

@elinguiuriel
Copy link
Contributor

Thank you @pixan198 for taking tame adding support for Gujarati. Unfortunately neither me nor @elinguiuriel speak Gujarati! We're waiting for community help on that one. would you recommend someone that can help ?

@pixan198 seems to be a native speaker, morphologically it seams OK, It's OK for me to merge his PR, another native speaker may update it later

@ashish11chawda
Copy link
Contributor Author

@aboullaite I couldn't find anyone right now, but it would be great if someone from community can help us for this.

@elinguiuriel Yes, I'm a native speaker of gujarati language.

@elinguiuriel elinguiuriel merged commit b26415c into fbdevelopercircles:master Aug 18, 2020
@elinguiuriel
Copy link
Contributor

@pixan198 I merge your PR as you can see, share it in your community
nice work 🥇

image

image

@ashish11chawda
Copy link
Contributor Author

@elinguiuriel Yes, it's working fine. 🤩

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants