-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
Arabic Translation Patch 1
Thank you @fady-a-m-ibrahim for the effort you put to add arabic support! However, the translation is a word to word translation, instead of semantic translation, which is very important in our case. |
Thank you @aboullaite for your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fady-a-m-ibrahim check my review, Others have more or less the same issue
Adding punctuations Adding ملفات الأكواد Use Fork instead of تفريع Removing (VCS) Remove (IDE) Using Code instead of الرمز And others
Arabic Translation Patch 2
Hello @aboullaite, Hoping you are doing fine. |
Sounds good! Also, all files should have this license header
|
Adding license header for Arabic translation
Thank you @aboullaite for your support. |
# This source code is licensed under the MIT license found in the | ||
# LICENSE file in the root directory of this source tree. | ||
# | ||
# Arabic translations for PROJECT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fady-a-m-ibrahim a file can only have one copyright, please remove this.
# | ||
msgid "" | ||
msgstr "" | ||
"Project-Id-Version: PROJECT VERSION\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put the project name here Arabic translation
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n" | ||
"POT-Creation-Date: 2020-08-15 20:37+0200\n" | ||
"PO-Revision-Date: 2020-08-15 12:58+0200\n" | ||
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put your name and address here !
Removing duplicate License in messages.po of Arabic translation.
Removing duplicate License of Arabic translation
Thank you @elinguiuriel |
@fady-a-m-ibrahim LGTM, @aboullaite will have a last look as an Arabic speaker and merge your PR, very nice work 🥇 |
Thank you for bearing with us @fady-a-m-ibrahim throughout this PR! Great work |
I do appreciate your help @elinguiuriel during this PL. Great Thank you. |
Thank you @aboullaite for all your support and nice comments. I do appreciate it. |
@fady-a-m-ibrahim make sure to set Arabic as your Facebook language and test the chatbot here: https://m.me/OpenSourceChatbot After many challenges #122 and #123, I was able to make Arabic works |
Thanks a lot @elinguiuriel 🙏👌 |
Is your pull request related to a problem? Please describe
The PR related to the issue Internalization: Add your local language #57
Describe the solution you'd like
Add the Arabic translation to src/locales/ar/LC_MESSAGES/messages.po and src/services/profile.py.
Test plan
There are no new tests added.