Skip to content
This repository has been archived by the owner on Apr 1, 2022. It is now read-only.

Arabic translation #116

Merged
merged 10 commits into from
Aug 20, 2020
Merged

Conversation

Fady-Ibra
Copy link
Contributor

@Fady-Ibra Fady-Ibra commented Aug 16, 2020

Is your pull request related to a problem? Please describe

The PR related to the issue Internalization: Add your local language #57

Describe the solution you'd like

Add the Arabic translation to src/locales/ar/LC_MESSAGES/messages.po and src/services/profile.py.

Test plan

There are no new tests added.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 16, 2020
@aboullaite
Copy link
Contributor

Thank you @fady-a-m-ibrahim for the effort you put to add arabic support! However, the translation is a word to word translation, instead of semantic translation, which is very important in our case.

@Fady-Ibra
Copy link
Contributor Author

Thank you @aboullaite for your comment.
Could you please give me an example of a word to word translation and the semantic translation that should be.

Copy link
Contributor

@aboullaite aboullaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fady-a-m-ibrahim check my review, Others have more or less the same issue

Adding punctuations 
Adding ملفات الأكواد
Use Fork instead of تفريع
Removing (VCS) 
Remove (IDE)
Using Code instead of الرمز
And others
@Fady-Ibra
Copy link
Contributor Author

Hello @aboullaite, Hoping you are doing fine.
There is an update, I have resolved the conflict in src/services/profile.py
Great Thank you,

@aboullaite
Copy link
Contributor

Sounds good! Also, all files should have this license header

# Copyright (c) Facebook, Inc. and its affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

@Fady-Ibra
Copy link
Contributor Author

Thank you @aboullaite for your support.
I have added the license header.

# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.
#
# Arabic translations for PROJECT.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fady-a-m-ibrahim a file can only have one copyright, please remove this.

#
msgid ""
msgstr ""
"Project-Id-Version: PROJECT VERSION\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put the project name here Arabic translation

"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
"POT-Creation-Date: 2020-08-15 20:37+0200\n"
"PO-Revision-Date: 2020-08-15 12:58+0200\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put your name and address here !

Removing duplicate License in messages.po of Arabic translation.
Removing duplicate License of Arabic translation
@Fady-Ibra
Copy link
Contributor Author

Thank you @elinguiuriel
I have removed the second copyright.

@elinguiuriel
Copy link
Contributor

Thank you @elinguiuriel
I have removed the second copyright.

@fady-a-m-ibrahim LGTM, @aboullaite will have a last look as an Arabic speaker and merge your PR, very nice work 🥇

@aboullaite aboullaite merged commit b08f462 into fbdevelopercircles:master Aug 20, 2020
@aboullaite
Copy link
Contributor

aboullaite commented Aug 20, 2020

Thank you for bearing with us @fady-a-m-ibrahim throughout this PR! Great work

@Fady-Ibra
Copy link
Contributor Author

I do appreciate your help @elinguiuriel during this PL. Great Thank you.

@Fady-Ibra
Copy link
Contributor Author

Thank you @aboullaite for all your support and nice comments. I do appreciate it.

@elinguiuriel
Copy link
Contributor

elinguiuriel commented Aug 20, 2020

@fady-a-m-ibrahim make sure to set Arabic as your Facebook language and test the chatbot here: https://m.me/OpenSourceChatbot

After many challenges #122 and #123, I was able to make Arabic works

image

image

@aboullaite
Copy link
Contributor

Thanks a lot @elinguiuriel 🙏👌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants