Add edge case tests and fix duplicate source ID validation

src/config-schema.ts

@@ -2,38 +2,44 @@ import { z } from "zod";
 
 export const TargetModeSchema = z.enum(["symlink", "copy"]);
 export const CacheModeSchema = z.enum(["materialize"]);
-export const IntegritySchema = z.object({
-	type: z.enum(["commit", "manifest"]),
-	value: z.string().nullable(),
-});
+export const IntegritySchema = z
+	.object({
+		type: z.enum(["commit", "manifest"]),
+		value: z.string().nullable(),
+	})
+	.strict();
 
-export const DefaultsSchema = z.object({
-	ref: z.string().min(1),
-	mode: CacheModeSchema,
-	include: z.array(z.string().min(1)).min(1),
-	targetMode: TargetModeSchema.optional(),
-	depth: z.number().min(1),
-	required: z.boolean(),
-	maxBytes: z.number().min(1),
-	maxFiles: z.number().min(1).optional(),
-	allowHosts: z.array(z.string().min(1)).min(1),
-});
+export const DefaultsSchema = z
+	.object({
+		ref: z.string().min(1),
+		mode: CacheModeSchema,
+		include: z.array(z.string().min(1)).min(1),
+		targetMode: TargetModeSchema.optional(),
+		depth: z.number().min(1),
+		required: z.boolean(),
+		maxBytes: z.number().min(1),
+		maxFiles: z.number().min(1).optional(),
+		allowHosts: z.array(z.string().min(1)).min(1),
+	})
+	.strict();
 
-export const SourceSchema = z.object({
-	id: z.string().min(1),
-	repo: z.string().min(1),
-	targetDir: z.string().min(1).optional(),
-	targetMode: TargetModeSchema.optional(),
-	ref: z.string().min(1).optional(),
-	mode: CacheModeSchema.optional(),
-	depth: z.number().min(1).optional(),
-	include: z.array(z.string().min(1)).optional(),
-	exclude: z.array(z.string().min(1)).optional(),
-	required: z.boolean().optional(),
-	maxBytes: z.number().min(1).optional(),
-	maxFiles: z.number().min(1).optional(),
-	integrity: IntegritySchema.optional(),
-});
+export const SourceSchema = z
+	.object({
+		id: z.string().min(1),
+		repo: z.string().min(1),
+		targetDir: z.string().min(1).optional(),
+		targetMode: TargetModeSchema.optional(),
+		ref: z.string().min(1).optional(),
+		mode: CacheModeSchema.optional(),
+		depth: z.number().min(1).optional(),
+		include: z.array(z.string().min(1)).optional(),
+		exclude: z.array(z.string().min(1)).optional(),
+		required: z.boolean().optional(),
+		maxBytes: z.number().min(1).optional(),
+		maxFiles: z.number().min(1).optional(),
+		integrity: IntegritySchema.optional(),
+	})
+	.strict();
 
 export const ConfigSchema = z
 	.object({

src/config.ts

@@ -318,6 +318,21 @@ export const validateConfig = (input: unknown): DocsCacheConfig => {
 		return source;
 	});
 
+	// Validate unique source IDs
+	const idSet = new Set<string>();
+	const duplicates: string[] = [];
+	for (const source of sources) {
+		if (idSet.has(source.id)) {
+			duplicates.push(source.id);
+		}
+		idSet.add(source.id);
+	}
+	if (duplicates.length > 0) {
+		throw new Error(
+			`Duplicate source IDs found: ${duplicates.join(", ")}. Each source must have a unique ID.`,
+		);
+	}
+
 	return {
 		cacheDir,
 		targetMode: targetModeOverride,