Skip to content

fix: certificate PDF download URL formatting #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igobranco merged 1 commit into from
Mar 11, 2026
+3 −3
Merged

fix: certificate PDF download URL formatting #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nau_openedx_extensions/certificate_export/management/commands/export_course_certificates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def handle(self, *args, **options):
# iterate each certificate and append each certificate as a row
for certificate in course_generated_certificates:
certificate_web_link_url = f"{lms_root_url}/certificates/{certificate.verify_uuid}"
certificate_download_pdf_link = certificate_download_url + certificate.verify_uuid
certificate_download_pdf_link = f"{certificate_download_url}/{certificate.verify_uuid}"

rows.append(
[
Expand Down
4 changes: 2 additions & 2 deletions nau_openedx_extensions/certificate_export/tests/test_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ def setUp(self):
super().setUp()
self.valid_course_id = "course-v1:NAU+Demo+DemoCourse"
self.valid_course_key = CourseKey.from_string(self.valid_course_id)
self.valid_download_url = "https://example.com/certificates/"
self.valid_download_url = "https://example.com/certificates"
self.lms_root_url = "https://lms.example.com"

# Use the renamed import
Expand Down Expand Up @@ -628,7 +628,7 @@ def test_csv_content_format(self, mock_generated_certificate, mock_upload_csv,
self.assertEqual(data_row[6], expected_web_link)

# Verify download link format
expected_download_link = f"{self.valid_download_url}test-uuid-123"
expected_download_link = f"{self.valid_download_url}/test-uuid-123"
self.assertEqual(data_row[7], expected_download_link)

@patch_use_read_replica
Expand Down