Fix transform function to always return node #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transform() function was missing a return statement, which caused it to implicitly return None in most cases. According to Astroid's transform contract, transforms should always return the node (even if unmodified) to ensure the transform chain continues properly. Without this fix: - When the condition is False, the function returns None - This breaks the transform chain for subsequent transforms - Related to astroid issue #809 This fix ensures the transform always returns the node, allowing other plugins' transforms to execute correctly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
@joce LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
Summary
Adds missing return statement in
transform() function to comply with Astroid's transform contract.Problem
The
transform()function currently returnsNoneimplicitly in most cases, which can break the transform chain when other plugins withFunctionDeftransforms are loaded afterpylint-pydantic.Changes
return nodestatement at line 78transform_pydantic_json()already handles returns in the same fileTesting
Related
Impact