-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing all 4 typical "messages" as in proftpd and other commercial FTP servers (taking over) #435
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
==========================================
+ Coverage 86.49% 86.66% +0.17%
==========================================
Files 11 11
Lines 1607 1620 +13
==========================================
+ Hits 1390 1404 +14
+ Misses 151 149 -2
- Partials 66 67 +1 ☔ View full report in Codecov by Sentry. |
It's not documented either by explanation or tests so we might as well remove it.
It seems to me it never worked like it should have.
So @syncplify & @drakkan, what do you think about this? This seems like a nice feature to add and a good time to create a new release. |
I agree. Apologies for mixing in the second change which should have been its own PR. You're right to drop that. I'll do a new and detailed PR once I have time to explore the observation @drakkan made about that. But the primary feature of this PR is highly desirable so I'd be very happy to see it included in your next release. Thanks. |
9983510
to
0aa7a8a
Compare
To explain the little pull requests and branches I have pushed... I have invested little time in it and faced a few issues.
So now I try to understand why we have these differences: I suspect it's because of the golangci-lint's cache... |
Taking over from #422