Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing all 4 typical "messages" as in proftpd and other commercial FTP servers (taking over) #435

Merged
merged 20 commits into from
Mar 2, 2024

Conversation

fclairamb
Copy link
Owner

Taking over from #422

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.66%. Comparing base (ad78d02) to head (02469ea).

Files Patch % Lines
handle_misc.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   86.49%   86.66%   +0.17%     
==========================================
  Files          11       11              
  Lines        1607     1620      +13     
==========================================
+ Hits         1390     1404      +14     
+ Misses        151      149       -2     
- Partials       66       67       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fclairamb fclairamb changed the title Syncplify's Custom messages Implementing all 4 typical "messages" as in proftpd and other commercial FTP servers (taking over) Feb 25, 2024
@fclairamb
Copy link
Owner Author

So @syncplify & @drakkan, what do you think about this?

This seems like a nice feature to add and a good time to create a new release.

@syncplify
Copy link
Contributor

I agree. Apologies for mixing in the second change which should have been its own PR. You're right to drop that. I'll do a new and detailed PR once I have time to explore the observation @drakkan made about that. But the primary feature of this PR is highly desirable so I'd be very happy to see it included in your next release. Thanks.

@fclairamb
Copy link
Owner Author

To explain the little pull requests and branches I have pushed...

I have invested little time in it and faced a few issues.

  • I made a working version and added this PR.
  • The next day, I changed core parts of the testing code and faced some race conditions
  • One week later (now) I tried to revert the code but now I have a problem with golangci-lint that won't even valide the same code push... And now I'm not sure how to proceed.

So now I try to understand why we have these differences:

I suspect it's because of the golangci-lint's cache...

@fclairamb fclairamb merged commit e57293e into main Mar 2, 2024
6 checks passed
@fclairamb fclairamb deleted the syncplify-custom-messages branch March 2, 2024 15:54
@fclairamb fclairamb restored the syncplify-custom-messages branch March 2, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants