fix: Issue of DataSource subclasses using parent abstract class docstrings #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dandawg <[email protected]>
franciscojavierarceo
approved these changes
Nov 1, 2024
sudohainguyen
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a natural continuation of the work done in this PR: [PR](fix: Fixed SparkSource docstrings so it wouldn't used inhereted class docstrings).
There were other DataSource subclasses that had the same issue--using the abstract class docstring (and
__init__docstring, which did not accurately describe the parameters and functionality of the specialized subclasses.I have added class docstrings and class
__init__docstrings where they were missing for subclasses of theDataSourceclass.Which issue(s) this PR fixes:
Misc