all kysely tests passing

featherscloud · Apr 4, 2024 · 3117da5 · 3117da5
1 parent 1654d10
commit 3117da5
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 60 deletions.
diff --git a/packages/kysely/src/index.ts b/packages/kysely/src/index.ts
@@ -114,7 +114,8 @@ export class KyselyAdapter<
   createQuery(options: KyselyOptions<Tables>, filters: any, query: any) {
     const q = this.startSelectQuery(options, filters)
     const qWhere = this.applyWhere(q, query)
-    const qLimit = filters.$limit ? qWhere.limit(filters.$limit) : qWhere
+    // if limit isn't provided but skip is, set limit to 10. Really, people should be specific in their query limit
+    const qLimit = filters.$limit ? qWhere.limit(filters.$limit) : filters.$skip ? qWhere.limit(10) : qWhere
     const qSkip = filters.$skip ? qLimit.offset(filters.$skip) : qLimit
     const qSorted = this.applySort(qSkip as any, filters)
     return qSorted

diff --git a/packages/kysely/test/index.test.ts b/packages/kysely/test/index.test.ts
@@ -10,64 +10,64 @@ const dialect = new SqliteDialect({
 })
 
 const testSuite = adapterTests([
-  // '.id',
-  // '.options',
-  // '.get',
-  // '.get + $select',
-  // '.get + id + query',
-  // '.get + NotFound',
-  // '.get + id + query id',
-  // '.find',
-  // '.find + paginate + query',
-  // '.find + $and',
-  // '.find + $and + $or',
-  // '.remove',
-  // '.remove + $select',
-  // '.remove + id + query',
-  // '.remove + multi',
-  // '.remove + multi no pagination',
-  // '.remove + id + query id',
-  // '.update',
-  // '.update + $select',
-  // '.update + id + query',
-  // '.update + NotFound',
-  // '.update + id + query id',
-  '.update + query + NotFound'
-  // '.patch',
-  // '.patch + $select',
-  // '.patch + id + query',
-  // '.patch multiple',
-  // '.patch multiple no pagination',
-  // '.patch multi query same',
-  // '.patch multi query changed',
-  // '.patch + query + NotFound',
-  // '.patch + NotFound',
-  // '.patch + id + query id',
-  // '.create',
-  // '.create ignores query',
-  // '.create + $select',
-  // '.create multi',
-  // '.find + equal',
-  // '.find + equal multiple',
-  // '.find + $sort',
-  // '.find + $limit',
-  // '.find + $limit 0',
-  // '.find + $skip',
-  // '.find + $select',
-  // '.find + $or',
-  // '.find + $in',
-  // '.find + $nin',
-  // '.find + $lt',
-  // '.find + $lte',
-  // '.find + $gt',
-  // '.find + $gte',
-  // '.find + $ne',
-  // '.find + $gt + $lt + $sort',
-  // '.find + $or nested + $sort',
-  // '.find + paginate',
-  // '.find + paginate + $limit + $skip',
-  // '.find + paginate + $limit 0',
-  // '.find + paginate + params'
+  '.id',
+  '.options',
+  '.get',
+  '.get + $select',
+  '.get + id + query',
+  '.get + NotFound',
+  '.get + id + query id',
+  '.find',
+  '.find + paginate + query',
+  '.find + $and',
+  '.find + $and + $or',
+  '.remove',
+  '.remove + $select',
+  '.remove + id + query',
+  '.remove + multi',
+  '.remove + multi no pagination',
+  '.remove + id + query id',
+  '.update',
+  '.update + $select',
+  '.update + id + query',
+  '.update + NotFound',
+  '.update + id + query id',
+  '.update + query + NotFound',
+  '.patch',
+  '.patch + $select',
+  '.patch + id + query',
+  '.patch multiple',
+  '.patch multiple no pagination',
+  '.patch multi query same',
+  '.patch multi query changed',
+  '.patch + query + NotFound',
+  '.patch + NotFound',
+  '.patch + id + query id',
+  '.create',
+  '.create ignores query',
+  '.create + $select',
+  '.create multi',
+  '.find + equal',
+  '.find + equal multiple',
+  '.find + $sort',
+  '.find + $limit',
+  '.find + $limit 0',
+  '.find + $skip',
+  '.find + $select',
+  '.find + $or',
+  '.find + $in',
+  '.find + $nin',
+  '.find + $lt',
+  '.find + $lte',
+  '.find + $gt',
+  '.find + $gte',
+  '.find + $ne',
+  '.find + $gt + $lt + $sort',
+  '.find + $or nested + $sort',
+  '.find + paginate',
+  '.find + paginate + $limit + $skip',
+  '.find + paginate + $limit 0',
+  '.find + paginate + params'
 ])
 
 interface Tables {
@@ -89,7 +89,7 @@ describe('Wings kysely Adapter', () => {
       .createTable('people')
       .addColumn('id', 'integer', (col) => col.primaryKey())
       .addColumn('name', 'varchar', (col) => col.notNull())
-      .addColumn('age', 'integer', (col) => col.notNull())
+      .addColumn('age', 'integer')
       .addColumn('created', 'boolean')
       .execute()
   })