Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip 502 related test failure (#1205) #1206

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Skip 502 related test failure (#1205) #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc4b508
Skip 502 related test failure (#1205)
xiaoyongzhu Jul 20, 2023
f5f70c2
Skip 502 tests
xiaoyongzhu Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions feathr_project/test/test_registry_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from feathr.definition.source import INPUT_CONTEXT, HdfsSource, InputContext
from feathr.definition.transformation import ExpressionTransformation, WindowAggTransformation
from feathr.definition.typed_key import TypedKey
import unittest, pytest

from feathr.registry._feathr_registry_client import (
_FeatureRegistry,
Expand Down Expand Up @@ -219,7 +220,7 @@ def test_parse_project():
)
assert len(derived_features) == 3


@pytest.mark.skip(reason="Skip since we cannot connect to external database")
def test_registry_client_list_features():
c = _FeatureRegistry(project_name="p", endpoint="https://feathr-sql-registry.azurewebsites.net/api/v1")
f = [e["qualifiedName"] for e in c.list_registered_features("feathr_ci_registry_getting_started")]
Expand All @@ -228,7 +229,7 @@ def test_registry_client_list_features():
for i in f:
assert i.startswith("feathr_ci_registry_getting_started__")


@pytest.mark.skip(reason="Skip since we cannot connect to external database")
def test_registry_client_load():
c = _FeatureRegistry(project_name="p", endpoint="https://feathr-sql-registry.azurewebsites.net/api/v1")
(anchors, derived_features) = c.get_features_from_registry("feathr_ci_registry_getting_started")
Expand All @@ -246,7 +247,7 @@ def test_registry_client_load():
)
assert len(derived_features) == 2


@pytest.mark.skip(reason="Skip since we cannot connect to external database")
def test_create():
project_name = f"feathr_registry_client_test_{int(time.time())}"
c = _FeatureRegistry(project_name="p", endpoint="https://feathr-sql-registry.azurewebsites.net/api/v1")
Expand Down
2 changes: 1 addition & 1 deletion registry/test/test_sql_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def create_and_get_derived_feature(self, project_id, qualified_name, name, featu
af1_downstream_entities = self.registry.get_dependent_entities(af_id)
assert len(af1_downstream_entities) > 0
return df_id

@pytest.mark.skip(reason="Skip since we cannot connect to external database")
def test_registry(self):
self.setup()
now = datetime.now()
Expand Down
Loading