Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LINT-83(feedback): Make public-api-boundaries less strict #87

Merged
merged 4 commits into from
Feb 4, 2022
Merged

LINT-83(feedback): Make public-api-boundaries less strict #87

merged 4 commits into from
Feb 4, 2022

Conversation

Krakazybik
Copy link
Member

@Krakazybik Krakazybik commented Feb 2, 2022 •
edited
Loading

Description

Добавлено:

  • лайт версия public-api правила

References

#75 #83

Checklist

  • Description added
  • Self-reviewed
  • CI pass

@Krakazybik Krakazybik self-assigned this Feb 2, 2022
@Krakazybik Krakazybik added the feature New feature or request label Feb 2, 2022
@Krakazybik Krakazybik linked an issue Feb 2, 2022 that may be closed by this pull request
LINT: (Feedback) Make public-api-boundaries less strict #83
Closed
@Krakazybik Krakazybik requested a review from azinit February 2, 2022 19:10
azinit
azinit suggested changes Feb 3, 2022
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит как достойный кандидат для лайт-конфига, но кое-что поправить бы)

rules/public-api/lite.test.js Show resolved Hide resolved
rules/public-api/lite.js Show resolved Hide resolved
rules/public-api/lite.js Show resolved Hide resolved
rules/public-api/lite.test.js Show resolved Hide resolved
rules/public-api/lite.test.js Show resolved Hide resolved
@Krakazybik Krakazybik requested a review from azinit February 3, 2022 18:47
azinit
azinit approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну, похоже шансов нет

Свету придется увидеть лайтовый PublicAPI))

Спасибище за упорный подход даже для таких блокирующих задач 🚀

package.json Show resolved Hide resolved
rules/public-api/lite.js Show resolved Hide resolved
rules/public-api/lite.test.js Show resolved Hide resolved
@azinit azinit merged commit 7d2561e into master Feb 4, 2022
@azinit azinit deleted the feat/LINT-83-less-strict-public-api branch February 4, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azinit azinit azinit approved these changes

Assignees

@Krakazybik Krakazybik

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LINT: (Feedback) Make public-api-boundaries less strict
2 participants
@Krakazybik @azinit