Create @fedify/nextjs to integrate with Next.js
#355
Conversation
`fedifyRequestHanlder` -> `fedifyRequestHandler`
Because `.pnpm-store/` breaks down at every execution of `pnpm install`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @2chanhaeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've introduced a new @fedify/nextjs package to seamlessly integrate Fedify with Next.js applications. This change also updates the CLI's init command, allowing users to easily scaffold new Fedify projects with Next.js as their chosen web framework, significantly improving the developer experience for building federated applications on Next.js.
Highlights
- New @fedify/nextjs Package: I've created a dedicated @fedify/nextjs package, providing core utilities like fedifyWith for Next.js middleware and integrateFederation for handling federation requests, enabling Fedify to run within Next.js environments.
- Enhanced CLI init Command: The fedify cli init command now supports Next.js, allowing users to generate a new project with a pre-configured Next.js setup, including necessary dependencies and a middleware.ts template for Fedify integration.
- Project Configuration Updates: I've updated the .gitignore to include .pnpm-store/ and adjusted pnpm-lock.yaml and pnpm-workspace.yaml to incorporate the new @fedify/nextjs package and its dependencies, ensuring proper project setup and dependency management.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
github-actions
bot
added
component/integration
There was a problem hiding this comment.
Code Review
This pull request introduces a new package, @fedify/nextjs, to integrate Fedify with Next.js. It also adds a Next.js option to the cli init command for easy project scaffolding. The changes look good overall, but I've found a few issues. There's a type issue with a default function parameter in the new Next.js package that could lead to runtime errors. The CLI template for Next.js is missing an important import, which would cause an error for users. I've also pointed out some redundant code in the CLI configuration for consistency. My review includes suggestions to fix these issues.
fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment)
fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment)
fedify-dev#355 (comment) If you need it, you can use this instead of `fedifyWith`: ```ts // middleware.ts import { hasFederationAcceptHeader, integrateFederation } from "@fedify/next"; import { getXForwardedRequest } from "x-forwarded-fetch"; export default function middleware(request: Request) { if(hasFederationAcceptHeader(request) { integrateFederation(getXForwardedRequest(request)) } } ```
|
The docs for this pull request have been published: |
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment)
fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment) Rename `@fedify/nextjs` to `@fedify/next` fedify-dev#355 (comment)
fedify-dev#355 (comment) If you need it, you can use this instead of `fedifyWith`: ```ts // middleware.ts import { hasFederationAcceptHeader, integrateFederation } from "@fedify/next"; import { getXForwardedRequest } from "x-forwarded-fetch"; export default function middleware(request: Request) { if(hasFederationAcceptHeader(request) { integrateFederation(getXForwardedRequest(request)) } } ```
Summary
Create
@fedify/nextjsto integrate with Next.js and add Next.js option forcli initRelated Issue
@fedify/next. #356Changes
pacakges/nextjs.cli init.examples/next15-app-router.Benefits
Now users can conveniently use Next.js and Fedify together more easier.
Checklist
Did you write a regression test to reproduce the bug (if it's a bug fix)?Not a bug fix.For the test, deployment is required.(I think)
deno task test-allon your machine?Additional Notes
A subissue needs to fix Next.js example #356