-
-
Notifications
You must be signed in to change notification settings - Fork 80
Hotfix @fedify/next
#370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix @fedify/next
#370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @2chanhaeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This hotfix addresses critical issues within the @fedify/next
package by updating its module resolution configuration, adjusting Next.js-specific error handling, and upgrading key dependencies. The changes ensure the package functions correctly and is compatible with newer versions of its underlying frameworks.
Highlights
- Module Resolution Fix for
@fedify/next
: Thepackage.json
for@fedify/next
was updated to standardize module and export paths, ensuring that both CommonJSrequire
and ES moduleimport
statements correctly resolve to the compiled JavaScript files (.js
) instead of mixed.mjs
and.d.mts
paths. - Improved Next.js
notFound
Handling: Thesrc/index.ts
file in@fedify/next
now uses a customonNotFound
function that returns a standardResponse
with a 404 status, replacing the direct dependency on Next.js'snotFound
utility. This provides a more robust and framework-agnostic error response. - Core Dependency Upgrades: The project's
pnpm-lock.yaml
andpnpm-workspace.yaml
files have been updated to reflect upgrades for thenext
framework (from15.4.2-canary
to15.4.6
) andtypescript
(from5.8.3
to5.9.2
), ensuring compatibility and leveraging the latest features and fixes from these foundational libraries.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a hotfix for the @fedify/next
package. It addresses a likely issue with notFound
handling in Next.js middleware by replacing the notFound
import from next/navigation
with a custom function that returns a 404 Response. The changes also include updating module paths in package.json
to align with the build output and bumping dependencies like next
and typescript
. The code changes appear correct and beneficial. My main feedback is that the documentation in packages/next/README.md
has become outdated due to these changes and should be updated to reflect the new implementation.
To avoid issues in the future you probably also want to enable arethetypesright with the |
Also, keep in mind this is esm only, as tsdown isn't building for cjs currently |
8eac7cd
to
49ea1a8
Compare
cc2d19e
to
513245d
Compare
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The docs for this pull request have been published: |
Summary
Fix
@fedify/next
Related Issue
@fedify/next
can't import and other problems #369Changes
packages/next
pnpm-*.yaml
Benefits
@fedify/next
will work.Checklist
deno task test-all
on your machine?Additional Notes
Include any other information, context, or considerations.