Skip to content

Conversation

2chanhaeng
Copy link
Contributor

Summary

Fix @fedify/next

Related Issue

Changes

  • packages/next
  • pnpm-*.yaml

Benefits

@fedify/next will work.

Checklist

  • Did you add a changelog entry to the CHANGES.md?
  • Did you write some relevant docs about this change (if it's a new feature)?
  • Did you write a regression test to reproduce the bug (if it's a bug fix)?
  • Did you write some tests for this change (if it's a new feature)?
  • Did you run deno task test-all on your machine?

Additional Notes

Include any other information, context, or considerations.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @2chanhaeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This hotfix addresses critical issues within the @fedify/next package by updating its module resolution configuration, adjusting Next.js-specific error handling, and upgrading key dependencies. The changes ensure the package functions correctly and is compatible with newer versions of its underlying frameworks.

Highlights

  • Module Resolution Fix for @fedify/next: The package.json for @fedify/next was updated to standardize module and export paths, ensuring that both CommonJS require and ES module import statements correctly resolve to the compiled JavaScript files (.js) instead of mixed .mjs and .d.mts paths.
  • Improved Next.js notFound Handling: The src/index.ts file in @fedify/next now uses a custom onNotFound function that returns a standard Response with a 404 status, replacing the direct dependency on Next.js's notFound utility. This provides a more robust and framework-agnostic error response.
  • Core Dependency Upgrades: The project's pnpm-lock.yaml and pnpm-workspace.yaml files have been updated to reflect upgrades for the next framework (from 15.4.2-canary to 15.4.6) and typescript (from 5.8.3 to 5.9.2), ensuring compatibility and leveraging the latest features and fixes from these foundational libraries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added component/integration Web framework integration priority/medium Medium priority issues runtime/node Node.js runtime related type/bug Something isn't working labels Aug 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a hotfix for the @fedify/next package. It addresses a likely issue with notFound handling in Next.js middleware by replacing the notFound import from next/navigation with a custom function that returns a 404 Response. The changes also include updating module paths in package.json to align with the build output and bumping dependencies like next and typescript. The code changes appear correct and beneficial. My main feedback is that the documentation in packages/next/README.md has become outdated due to these changes and should be updated to reflect the new implementation.

@ThisIsMissEm
Copy link
Contributor

To avoid issues in the future you probably also want to enable arethetypesright with the attw option in tsdown

@ThisIsMissEm
Copy link
Contributor

Also, keep in mind this is esm only, as tsdown isn't building for cjs currently

@2chanhaeng 2chanhaeng changed the base branch from main to 1.8-maintenance August 15, 2025 01:50
@2chanhaeng 2chanhaeng changed the base branch from 1.8-maintenance to main August 22, 2025 05:32
Copy link
Contributor

The latest push to this pull request has been published to JSR and npm as a pre-release:

Package Version JSR npm
@fedify/fedify 1.9.0-pr.370.1389+513245df JSR npm
@fedify/cli 1.9.0-pr.370.1389+513245df JSR
@fedify/amqp 1.9.0-pr.370.1389+513245df JSR npm
@fedify/elysia 1.9.0-pr.370.1389+513245df npm
@fedify/express 1.9.0-pr.370.1389+513245df JSR npm
@fedify/h3 1.9.0-pr.370.1389+513245df JSR npm
@fedify/nestjs 1.9.0-pr.370.1389+513245df npm
@fedify/next 1.9.0-pr.370.1389+513245df npm
@fedify/postgres 1.9.0-pr.370.1389+513245df JSR npm
@fedify/redis 1.9.0-pr.370.1389+513245df JSR npm
@fedify/sqlite 1.9.0-pr.370.1389+513245df JSR npm
@fedify/testing 1.9.0-pr.370.1389+513245df JSR npm

Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

The docs for this pull request have been published:

https://e7b3a5ee.fedify.pages.dev

@dahlia dahlia merged commit daedc1c into fedify-dev:main Aug 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/integration Web framework integration priority/medium Medium priority issues runtime/node Node.js runtime related type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix @fedify/next can't import and other problems
3 participants