fix: remove duplicate actorDispatcher null check

[choidabom]

Summary

Removed duplicate actorDispatcher null check in WebFinger handler.

Related Issue

• fixes Duplicated code in handleWebFingerInternal #380

Changes

Removed duplicate actorDispatcher null check in WebFinger handler.

Benefits

Removes duplicate code to improve maintainability

Checklist

• Did you add a changelog entry to the CHANGES.md?
• Did you write some relevant docs about this change (if it's a new feature)?
• Did you write a regression test to reproduce the bug (if it's a bug fix)?
• Did you write some tests for this change (if it's a new feature)?
• Did you run deno task test-all on your machine?

Additional Notes

[gemini-code-assist]

Summary of Changes

Hello @choidabom, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a minor but impactful refactoring within the WebFinger handler. The primary goal is to improve code maintainability by removing a duplicate null check for the actorDispatcher. This change simplifies the logic flow and ensures that the same condition is not checked multiple times unnecessarily, contributing to a cleaner and more efficient codebase.

Highlights

• Code Refactoring: This change eliminates a redundant null check for the actorDispatcher within the WebFinger handler, streamlining the codebase and removing unnecessary repetition.
• Maintainability Improvement: By removing duplicate code, the pull request directly enhances the maintainability and readability of the WebFinger handler, making it easier for future developers to understand and modify.
• Bug Fix: The fix addresses and resolves issue #380 by cleaning up an unnecessary duplicate check, contributing to overall code quality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes a duplicate null check for actorDispatcher in the WebFinger handler, which improves code maintainability by removing redundant code. The change is logical and well-implemented. I have one suggestion regarding the log level used when actorDispatcher is not provided. Since this is an expected scenario, logging it as an error might be inappropriate and could cause false alarms. I've recommended changing it to a warning.

[dahlia]

@2chanhaeng Could you review this pull request?

[2chanhaeng]

Good! 👍

[github-actions]

The latest push to this pull request has been published to JSR and npm as a pre-release:

Package	Version	JSR	npm
@fedify/fedify	1.9.0-pr.383.1403+350a35b0	JSR	npm
@fedify/cli	1.9.0-pr.383.1403+350a35b0	JSR
@fedify/amqp	1.9.0-pr.383.1403+350a35b0	JSR	npm
@fedify/elysia	1.9.0-pr.383.1403+350a35b0		npm
@fedify/express	1.9.0-pr.383.1403+350a35b0	JSR	npm
@fedify/h3	1.9.0-pr.383.1403+350a35b0	JSR	npm
@fedify/nestjs	1.9.0-pr.383.1403+350a35b0		npm
@fedify/next	1.9.0-pr.383.1403+350a35b0		npm
@fedify/postgres	1.9.0-pr.383.1403+350a35b0	JSR	npm
@fedify/redis	1.9.0-pr.383.1403+350a35b0	JSR	npm
@fedify/sqlite	1.9.0-pr.383.1403+350a35b0	JSR	npm
@fedify/testing	1.9.0-pr.383.1403+350a35b0	JSR	npm

[github-actions]

The docs for this pull request have been published:

https://2254b7c5.fedify.pages.dev