Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Placeholder On Homepage #630

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Conversation

tsmith123
Copy link
Collaborator

@tsmith123 tsmith123 commented Mar 1, 2025

After some feedback in #628 this PR adds an example url as the placeholder on the Homepage to indicate it's a websocket url that's required.

Screenshot 2025-03-03 at 10 59 23

@tsmith123 tsmith123 requested a review from a team as a code owner March 1, 2025 15:16
Copy link

vercel bot commented Mar 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 8:38am

dpc
dpc previously requested changes Mar 2, 2025
Copy link
Contributor

@dpc dpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait. I think the port is wrong, and generally we shouldn't need to specify it anyway.

@alexlwn123 alexlwn123 merged commit 5294754 into master Mar 3, 2025
3 checks passed
@alexlwn123 alexlwn123 deleted the tom/restore-placeholder branch March 3, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants