Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes package.json breaking react example #111

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

wfzyx
Copy link
Contributor

@wfzyx wfzyx commented Jan 30, 2025

The react example wasn't building locally and at https://web.fedimint.org/examples/vite-react.html via StackBlitz

Copy link

changeset-bot bot commented Jan 30, 2025

⚠️ No Changeset found

Latest commit: 4645180

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

alexlwn123
alexlwn123 previously approved these changes Jan 30, 2025
Copy link
Member

@alexlwn123 alexlwn123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for the contribution!

@alexlwn123 alexlwn123 enabled auto-merge (squash) January 30, 2025 15:58
auto-merge was automatically disabled February 1, 2025 14:27

Head branch was pushed to by a user without write access

@wfzyx
Copy link
Contributor Author

wfzyx commented Feb 1, 2025

I missed the fact that the pipelines needs an up-to-date lock file on yaml format; that has been provided now;

@wfzyx wfzyx requested a review from alexlwn123 February 1, 2025 14:28
@alexlwn123 alexlwn123 enabled auto-merge (squash) February 1, 2025 16:26
@alexlwn123 alexlwn123 merged commit a09bfa7 into fedimint:main Feb 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants