Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require 5 blocks for mainnet #502

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

Kodylow
Copy link
Member

@Kodylow Kodylow commented Aug 16, 2024

Unsafe to run with less on mainnet, disables the option to go under 5

Summary by CodeRabbit

  • New Features

    • Enhanced Bitcoin settings form to display dynamic helper text based on the selected network.
    • Added context-sensitive information regarding block confirmations for Mainnet usage.
  • Improvements

    • Updated minimum block confirmation values based on the selected network, improving the form's responsiveness and user experience.

@Kodylow Kodylow requested a review from a team as a code owner August 16, 2024 22:15
Copy link
Contributor

coderabbitai bot commented Aug 16, 2024

Walkthrough

Walkthrough

The recent updates enhance the BitcoinSettingsForm by introducing dynamic helper text and adjustable minimum values for a form control based on the selected network. Specifically, the logic now distinguishes between Bitcoin and other networks, improving user guidance and experience. Additionally, a new localization entry clarifies the requirement for extra confirmations when operating on the Mainnet.

Changes

File(s) Change Summary
apps/guardian-ui/src/components/... Updated BitcoinSettingsForm to display dynamic helper text and set conditional minimum values for block confirmations.
apps/guardian-ui/src/languages/... Added new localization entry for Mainnet block confirmations, emphasizing the need for additional confirmations.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@elsirion elsirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help text could be better, but requiring 5 or 6 confirmations seems reasonable (although I'll surely work around it at some point because I'm reckless 🤣)

apps/guardian-ui/src/languages/en.json Show resolved Hide resolved
@elsirion elsirion merged commit 8dd31a7 into fedimint:master Aug 20, 2024
1 check passed
@Kodylow Kodylow deleted the require-5-blocks-mainnet branch September 13, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants