-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render template of teams and meetings data from yaml file #236
base: main
Are you sure you want to change the base?
Conversation
bc5069a
to
a0101fe
Compare
@darknao @t0xic0der please have a look to it and let me know if any corrections are needed |
03f2970
to
26bfdf7
Compare
@t0xic0der @darknao please check and let me know how it looks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me so long to review this...
For reference purpose: link to Marin design https://user-images.githubusercontent.com/799683/144504408-0031c0d5-684b-4e41-ba25-93942719489c.png
See if you can take a little step closer to this design when it comes to font choice, size, and color of the various elements in the team list.
@darknao thanks for the update. I will do the changes |
@t0xic0der @darknao done all the changes. Please have a look and let me know |
df23d74
to
ecea364
Compare
ecea364
to
736d5f7
Compare
736d5f7
to
681ccbd
Compare
99b4cda
to
a5af61d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that you have rebased your work, please remove requirements.txt
and add all missing required libraries to pyproject.toml
a5af61d
to
4e398f8
Compare
@darknao @t0xic0der I have done all the changes. Is this ready to be merged? |
Not yet. And the |
@darknao @t0xic0der resolved and updated all the dependencies in poetry.lock file. The checks are passing now. Now is this ready to be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I created a separate YAML file where I have listed all the teams and their associated meeting names. Then I created a new function which has read the team yaml file and then returned a new html page with every data in it. Thus to send html content, I used the function "render_template" where the first argument of this function is the teams.html template file which I created in the template directory. Used @main.get annotation with teams URL to get all the teams data.