Use size_t for sizes and indices instead of ptrdiff_t - #27
Closed
mizdebsk wants to merge 2 commits into
Closed
Conversation
Replace uses of std::ptrdiff_t with std::size_t for variables and parameters representing sizes and positions in string and span-like containers. This better reflects intent, avoids unnecessary signed/unsigned conversions, and aligns with common C++ conventions.
Member
|
I simply follow guidelines and a simple rule: use
I adopted this approach in most of my projects. |
Member
Author
|
I still think that size_t (or ssize_t) is the natural way of expressing sizes, not ptrdiff_t. |
Member
|
I want to keep everything signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace uses of std::ptrdiff_t with std::size_t for variables and parameters representing sizes and positions in string and span-like containers. This better reflects intent, avoids unnecessary signed/unsigned conversions, and aligns with common C++ conventions.