local_path argument development
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just needed to quote a column name in the `mutate()`.
In `get_hvw_data()` and the `local_file` helper functions.
Still needs testing.
Issue: converting between different file formats using `read_from_local_path`/`write_from_local_path`
Error handling, plus allow arbitrary-length file endings
And test/document changes
And remove it from documentation
Also: * only use `dplyr::any_of()` for the column names that actually vary by chamber. * `dplyr::matches()` regexes for the bill progress columns
* Add `read_from_local_path` argument to `fix_les_coltypes()` * Use `haven::as_factor()` when reading from DTA files
in `build_voteview_file_path()`, `build_hvw_url()`, `build_les_url()`, `match_congress()`, and `get_les()`.
Also, rename `full_path` to `url`, like in HVW.
to enable returning raw bytes where they're needed
* only use `lapply()` for *online* downloads of multiple congresses * `filter_congress()` and `filter_chamber()` for local reads (not yet tested)
when specifying a chamber from a local file. This makes it indistinguishable from a file you download from online.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
local_pathis the main improvement here. Other changes here:read_html_table(){cli}