Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addpatch: code #2791

Merged
merged 1 commit into from
Jul 11, 2023
Merged

addpatch: code #2791

merged 1 commit into from
Jul 11, 2023

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented Jul 6, 2023

  • Add missing riscv64 definition.
  • Skip browser downloads(they are not used at all).
  • Skip electron binary download. (No upstream binary available)
  • Create a zipped electron22 and put it in the cache to make the build process happy.
  • Build all native node extensions in debug mode to avoid segfaults and strange behaviors.
    • This bug needs further investigation.

@kxxt
addpatch: code
8d968d0 
- Add missing riscv64 definition.
- Skip browser downloads(they are not used at all).
- Skip electron binary download. (No upstream binary available)
- Create a zipped electron22 and put it in the cache to make the build
  process happy.
- Build all native node extensions in debug mode to avoid segfaults and
  strange behaviors.
  - This bug needs further investigation.
@kxxt
Copy link
Contributor Author

kxxt commented Jul 6, 2023

It is recommended to run code with --no-sandbox for now to avoid bugs.

BTW the electron22 in our repo is not working, which will be fixed in an upcoming PR.

@kxxt kxxt mentioned this pull request Jul 6, 2023
Open
@felixonmars felixonmars merged commit b1a306d into felixonmars:master Jul 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kxxt @felixonmars