Add showLayerDataTable method #31
Merged
+377
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhicks
force-pushed
the
tom/app-7281-toggle-data-table-state
branch
2 times, most recently
from
53af206 to
d024bec
Compare
noisyneuron
reviewed
Mar 17, 2025
docs/Main/FeltController.md
Outdated
| | Parameter | Type | | ||
| | ----------------- | ----------------------------------------------------------------------------- | | ||
| | `params` | \{ `layerId`: `string`; `sorting`: [`SortConfig`](../Shared/SortConfig.md); } | | ||
| | `params.layerId` | `string` | |
There was a problem hiding this comment.
should we make this optional, since felt ui supports showing the table without any layer
There was a problem hiding this comment.
you can't select layers in view mode so i don't think you could do anything with that option?
There was a problem hiding this comment.
presumably people using the sdk might have their own legend / layer selection mechanism, so it'll allow them to keep the "map view" in a stable state
no strong opinion though, whatever you think makes more sense
tomhicks
force-pushed
the
tom/app-7281-toggle-data-table-state
branch
2 times, most recently
from
cea2760 to
8f6f951
Compare
tomhicks
force-pushed
the
tom/app-7281-toggle-data-table-state
branch
from
8f6f951 to
ffb05e9
Compare
tomhicks
added a commit
that referenced
this pull request
Mar 20, 2025
* feat: add showLayerDataTable method with sorting capability * docs(changeset): Add showLayerDataTable method * Add hide method * Move to UiController * Allow opening table pane with no layer
tomhicks
added a commit
that referenced
this pull request
Apr 11, 2025
* RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Add prerelease files * RELEASING: Releasing 0 package(s) Releases: [skip ci] * Add getViewportConstraints and setViewportConstraints methods definition (#21) * docs(changeset): Add getViewportConstraints and setViewportConstraints methods definition * Add getViewportConstraints and setViewportConstraints methods definition * Improve doc * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease file * Programmatic element CRUD (#25) * Start defining element types * Add API for create/update/delete elements * WIP * Replace z.infer with zInfer and type with interface exports for better docs * Update type and schema names to be consistent * Make exports more consistent * Update element geometry to use tuples * Update circle * Update types, mostly required v optional * Rename pin to place and update position types * docs(changeset): Add programmatic element creation, editing and deletion * Fix tool settings types --------- Co-authored-by: Sergio Clebal <[email protected]> * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update pre.json * Add onElementCreate/Delete listeners (#26) * Polish programmatic element CRUD (#27) * Omit color on ImageElement. Omit coordinates and name on TextElement and NoteElement updates. Rename widthMultiplier as widthScale. * Prevent createElement and updateElement methods to return null * docs(changeset): Make programmatic element CRUD types more accurate * Update js-skd.api.md * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update pre.json * Add getMapDetails method definition (#22) * Add getMapDetails method definition * docs(changeset): Add getMapDetails method definition * Improve doc * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease file * Add methods for layer stats (#28) * Add methods for layer stats * docs(changeset): Add layer stats methods * Change calculation response shape * Update attributes for calculations * Rename * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease file * Reduce heading nesting (#33) * Reduce heading nesting * Update doc nesting level * Fix various doc examples and add better Filters docs (#32) * Fix various doc examples and add better Filters docs * Mention FilterTernary * Improve docs for filter ternaries * Include changelog in docs * Don't reduce changelog and top-level readme heading levels * Add updated changelog * Add coordinates to returned circle (#30) * docs(changeset): Add coordinates to circle * Return coords when reading a place * Add showLayerDataTable method (#31) * feat: add showLayerDataTable method with sorting capability * docs(changeset): Add showLayerDataTable method * Add hide method * Move to UiController * Allow opening table pane with no layer * Add onElementCreateEnd and isBeingCreated on element change payload (#37) Add new event for ending creating elements and meta on element create/change events * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update changelog in docs * Add onLayerFiltersChange listener (#39) * Add onLayerFiltersChange handler * docs(changeset): Add onLayerFiltersChange to allow listening to changes to layer filters, be it ephemeral, style or widget filters that changed. * Add support for PinToolSettings.afterCreation (#40) * Add support for PinToolSettings.afterCreation * docs(changeset): Add `afterCreation` option in pin tool settings to control what happens after creating a Place * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update changelog in docs * RELEASING: Releasing 0 package(s) Releases: [skip ci] * Update prerelease file * Add interaction option to elements to enable locking / unlocking (#34) * Add interaction option to elements * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Add RELEASING.md and update DEVELOPING.md (#43) * Add RELEASING.md and update DEVELOPING.md * Add new release script * Update docs and scripts * Update to explain npm login * Add blurb to landing page (#44) * add blurb to landing page * [docs] Improve setToolSettings types and other docs (#42) * Improve various docs * docs(changeset): Improves type readability and docs * Add getFeature (#41) * Add getFeature * docs(changeset): Add getFeature for getting a single feature as GeoJSON with full detail geometry * Fix missing method in schema * Update docs on LayerFeature.geometryType * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Add getLayerSchema and associated types (#45) * Add getLayerSchema and associated types * docs(changeset): Add getLayerSchema method * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Fix spelling mistake (#48) * RELEASING: Releasing 0 package(s) Releases: [skip ci] * docs(changeset): Fix spelling mistake in types * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Add handlers for geojson files and urls (#46) * Add handlers for geojson files and urls * Add delete and make create singular * docs(changeset): Add createEphemeralLayer and deleteLayer * Udpate sdk spec * change name to createLayer * format * update changeset --------- Co-authored-by: Sukanya Aneja <[email protected]> * Annotate listener as event (#47) * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Ensure geometry styles are retained when creating a layer with a file (#49) * Ensure geometry styles are retained when creating a layer with a file * Use spreading for clarity of what is overridden * docs(changeset): Fix per-geometry styling for created layers --------- Co-authored-by: Tom Hicks <[email protected]> * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Loosen constraint for passed window to allow workers to use SDK (#50) * Loosen constraint for passed window to allow workers to use SDK * docs(changeset): Allow workers to be SDK clients * Update API spec * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Fix various documentation issues (#51) * Fix various documentation issues * docs(changeset): Improve documentation * Update API spec * Fix unused schemas * Documentation fixes (#52) * correct afterCreation details * link to functions in docs * format, api * docs(changeset): Fixes incorrect value in documentation and updates links to other methods --------- Co-authored-by: Tom Hicks <[email protected]> * Improve element documentation generation and prose (#53) * Add documentation for element properties * Add element explanation and other improvements * docs(changeset): Improve element docs * Regen docs * docs(changeset): Change Circle.coordinates for Circle.center * Fix update types and change output order * Circle center * Document that marker and highlighter can return geometry, too (#54) * Document that marker and highlighter can return geometry, too * Allow showing holes in highlighters * docs(changeset): Change documentation for getElementGeoemtry to document Highlighter and Marker functionality, and allow holes in Highlighter geometry * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Throw errors from methods when validation fails (#57) * Throw errors from methods when validation fails * Extract error creation/checking * docs(changeset): Reject promises when method handlers are invalid * Add comment * Validate geometry for element creation and updates (#58) * Throw errors from methods when validation fails * Extract error creation/checking * docs(changeset): Reject promises when method handlers are invalid * Add comment * Validate geometry for element creation and updates * Add test for element validation * Improve deployment scripts * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Ensure bundle is a single file by inspecting content (#61) * Add support for multipolygon geometry filters (#60) * Extract GeometryFilter type * docs(changeset): Fix geometry filter type * Improve createLayer (#59) * Document ephemeral layer geometry styles * Unnest sources * docs(changeset): Improve createLayer API * Rename to createLayersFromGeoJson * Change return type * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Refactor and improve layer sources (#62) * Refactor layer sources * docs(changeset): Update Layer type and createLayerFromGeoJson to separate out Source concept * Remove data from data source response * Fix minor element type issue * Improve docs * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Fix text and note creation types (#64) * Fix text and note creation types * docs(changeset): Improve Text and Note types and docs * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Add screen point to pointer events (#63) * Add screen point to pointer events * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Add updateLayer (#65) * Add udpateLayer * Allow setting boundary, caption and description when creating layers * Fix Text and Note update position types * docs(changeset): Add updateLayer and expand createLayersFromGeoJson options * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Exit prerelease * Scrub changelog * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta * Update example * docs(changeset): Update getLayerSchema example * RELEASING: Releasing 1 package(s) Releases: @feltmaps/[email protected] [skip ci] * Update prerelease docs/meta --------- Co-authored-by: Sergio Clebal <[email protected]> Co-authored-by: sukanya <[email protected]> Co-authored-by: Sukanya Aneja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
showLayerDataTableandhideLayerDataTablemethods with sorting capability