Add showLayerDataTable method #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhicks
force-pushed
the
tom/app-7281-toggle-data-table-state
branch
2 times, most recently
from
53af206 to
d024bec
Compare
noisyneuron
reviewed
Mar 17, 2025
docs/Main/FeltController.md
Outdated
| | Parameter | Type | | ||
| | ----------------- | ----------------------------------------------------------------------------- | | ||
| | `params` | \{ `layerId`: `string`; `sorting`: [`SortConfig`](../Shared/SortConfig.md); } | | ||
| | `params.layerId` | `string` | |
There was a problem hiding this comment.
should we make this optional, since felt ui supports showing the table without any layer
There was a problem hiding this comment.
you can't select layers in view mode so i don't think you could do anything with that option?
There was a problem hiding this comment.
presumably people using the sdk might have their own legend / layer selection mechanism, so it'll allow them to keep the "map view" in a stable state
no strong opinion though, whatever you think makes more sense
tomhicks
force-pushed
the
tom/app-7281-toggle-data-table-state
branch
2 times, most recently
from
cea2760 to
8f6f951
Compare
tomhicks
force-pushed
the
tom/app-7281-toggle-data-table-state
branch
from
8f6f951 to
ffb05e9
Compare
tomhicks
added a commit
that referenced
this pull request
Mar 20, 2025
* feat: add showLayerDataTable method with sorting capability * docs(changeset): Add showLayerDataTable method * Add hide method * Move to UiController * Allow opening table pane with no layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
showLayerDataTableandhideLayerDataTablemethods with sorting capability