-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add showLayerDataTable method #31
base: main
Are you sure you want to change the base?
Conversation
53af206
to
d024bec
Compare
| Parameter | Type | | ||
| ----------------- | ----------------------------------------------------------------------------- | | ||
| `params` | \{ `layerId`: `string`; `sorting`: [`SortConfig`](../Shared/SortConfig.md); } | | ||
| `params.layerId` | `string` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we make this optional, since felt ui supports showing the table without any layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can't select layers in view mode so i don't think you could do anything with that option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
presumably people using the sdk might have their own legend / layer selection mechanism, so it'll allow them to keep the "map view" in a stable state
no strong opinion though, whatever you think makes more sense
d024bec
to
cea2760
Compare
cea2760
to
8f6f951
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
feat: add showLayerDataTable method with sorting capability
docs(changeset): Add showLayerDataTable method