Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showLayerDataTable method #31

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tomhicks
Copy link
Collaborator

feat: add showLayerDataTable method with sorting capability

docs(changeset): Add showLayerDataTable method

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tomhicks tomhicks force-pushed the tom/app-7281-toggle-data-table-state branch 2 times, most recently from 53af206 to d024bec Compare March 17, 2025 15:30
| Parameter | Type |
| ----------------- | ----------------------------------------------------------------------------- |
| `params` | \{ `layerId`: `string`; `sorting`: [`SortConfig`](../Shared/SortConfig.md); } |
| `params.layerId` | `string` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make this optional, since felt ui supports showing the table without any layer

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can't select layers in view mode so i don't think you could do anything with that option?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

presumably people using the sdk might have their own legend / layer selection mechanism, so it'll allow them to keep the "map view" in a stable state

no strong opinion though, whatever you think makes more sense

@tomhicks tomhicks force-pushed the tom/app-7281-toggle-data-table-state branch from d024bec to cea2760 Compare March 18, 2025 13:18
@tomhicks tomhicks force-pushed the tom/app-7281-toggle-data-table-state branch from cea2760 to 8f6f951 Compare March 19, 2025 09:27
Copy link
Collaborator

@noisyneuron noisyneuron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants