Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various doc examples and add better Filters docs #32

Merged
merged 5 commits into from
Mar 19, 2025
Merged

Fix various doc examples and add better Filters docs #32

merged 5 commits into from
Mar 19, 2025

Conversation

tomhicks
Copy link
Collaborator

@tomhicks tomhicks commented Mar 17, 2025 •
edited
Loading

What this does

  • improves Filters explanation due to user feedback and confusion around combining multiple ternaries
  • prevents reducing heading levels in some top-level markdown docs
  • includes the changelog in the docs
  • fixes some examples that used incorrect types
  • makes other examples more consistent in use of await etc.

@tomhicks Graphite App
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

noisyneuron
noisyneuron reviewed Mar 17, 2025
View reviewed changes
@tomhicks tomhicks force-pushed the tom/app-7295-various-sdk-docs-issues branch 2 times, most recently from 62c2469 to a41b096 Compare March 18, 2025 13:24
noisyneuron
noisyneuron approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@noisyneuron noisyneuron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@tomhicks tomhicks force-pushed the tom/app-7295-various-sdk-docs-issues branch from a41b096 to 48c95fb Compare March 19, 2025 09:17
@tomhicks tomhicks merged commit 7b334e7 into main Mar 19, 2025
2 of 3 checks passed
@tomhicks tomhicks deleted the tom/app-7295-various-sdk-docs-issues branch March 19, 2025 09:23
tomhicks added a commit that referenced this pull request Mar 19, 2025
@tomhicks
Fix various doc examples and add better Filters docs (#32)
1ec9c63 
* Fix various doc examples and add better Filters docs

* Mention FilterTernary

* Improve docs for filter ternaries

* Include changelog in docs

* Don't reduce changelog and top-level readme heading levels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisyneuron noisyneuron noisyneuron approved these changes

Assignees

@noisyneuron noisyneuron

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomhicks @noisyneuron