Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tippecanoe-decode and tippecanoe-overzoom changes to improve binning performance #292

Merged
merged 9 commits into from
Nov 8, 2024
Merged

Tippecanoe-decode and tippecanoe-overzoom changes to improve binning performance #292

merged 9 commits into from
Nov 8, 2024

Conversation

e-n-f
Copy link
Collaborator

@e-n-f e-n-f commented Nov 7, 2024 •
edited
Loading

  • Adds --no-tile-compression option to tippecanoe-overzoom
  • Makes tippecanoe-overzoom clip the output tile to the tile buffer after assigning points to bins
  • Adds --include/-y option to tippecanoe-decode to decode only specified attributes
  • Cleans up some inconsistent handling of variable tile extents in overzooming code
  • Speeds up overzooming slightly in tile-join by doing less preflighting to discover which child tiles contain features

@e-n-f e-n-f changed the title Add a tippecanoe-decode option to restrict which attributes to decode Tippecanoe-decode and tippecanoe-overzoom changes to improve binning performance Nov 7, 2024
@e-n-f e-n-f marked this pull request as ready for review November 8, 2024 22:20
ChrisLoer
ChrisLoer approved these changes Nov 8, 2024
View reviewed changes
Copy link

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walked through with Erica, changes make sense, did quick sanity check in Felt preview env.

@e-n-f e-n-f merged commit 794ae2b into main Nov 8, 2024
4 checks passed
@e-n-f e-n-f deleted the limit-decode-attributes branch November 8, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLoer ChrisLoer ChrisLoer approved these changes

@migurski migurski Awaiting requested review from migurski

@arredond arredond Awaiting requested review from arredond arredond is a code owner

@dnomadb dnomadb Awaiting requested review from dnomadb dnomadb is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-n-f @ChrisLoer