Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid crash if the first bin gets clipped away #294

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Avoid crash if the first bin gets clipped away #294

merged 3 commits into from
Nov 13, 2024

Conversation

e-n-f
Copy link
Collaborator

@e-n-f e-n-f commented Nov 13, 2024 •
edited
Loading

If the first bin was clipped away to nothing, there was a crash when the tippecanoe:count attribute was added to the nonexistent feature.

ChrisLoer
ChrisLoer approved these changes Nov 13, 2024
View reviewed changes
Copy link

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small defensive change -- I did just a very light verification that one of the affected tiles works with this change in Felt.

@e-n-f e-n-f merged commit 6d46578 into main Nov 13, 2024
4 checks passed
@e-n-f e-n-f deleted the bin-assign-crash branch November 13, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLoer ChrisLoer ChrisLoer approved these changes

@migurski migurski Awaiting requested review from migurski

@arredond arredond Awaiting requested review from arredond arredond is a code owner

@dnomadb dnomadb Awaiting requested review from dnomadb dnomadb is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-n-f @ChrisLoer