Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clipping bug when the clip region doesn't intersect the tile #312

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

e-n-f
Copy link
Collaborator

@e-n-f e-n-f commented Dec 11, 2024

A clip region specified only by bounding box and a clip region that had itself been entirely clipped away were both signified by an empty clip geometry. Don't generate any features when the clip region does not intersect the tile.

@e-n-f e-n-f marked this pull request as ready for review December 11, 2024 00:27
Copy link

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Felt.

@e-n-f e-n-f merged commit 7165ae6 into main Dec 11, 2024
10 checks passed
@e-n-f e-n-f deleted the clipped-away-clip-region branch December 11, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants