Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing fields on enum #2184

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brunokrebs
Copy link

No description provided.

@mrlubos
Copy link
Collaborator

mrlubos commented Jun 9, 2024

@brunokrebs would you like to provide context?

@brunokrebs
Copy link
Author

brunokrebs commented Jun 9, 2024

Hi, @mrlubos, sorry, ended up opening to see if CI would run, but it didn't.

Anyway, before realizing that this repo is no longer maintained, I cloned it into my computer, added a test case, and generated the snapshot that shows what I was going to report.

As you can see, if we have an enum with keys like +name and -name, and +total and -total, the library ends up ignoring the "opposite" key (of whatever comes first, + or -).

so, on the snapshot, we ended up with:

export enum EnumWithStringsWithPlusAndMinusSigns {
    _NAME = '+name',
    _TOTAL = '+total',
}

Instead of a type with four keys.

@brunokrebs brunokrebs marked this pull request as draft June 9, 2024 12:50
@mrlubos
Copy link
Collaborator

mrlubos commented Jun 9, 2024

@brunokrebs you got it with the deprecation notice. Feel free to open an issue in Hey API if this isn't fixed there yet.

@brunokrebs brunokrebs changed the title opposite Missing Keys Jun 9, 2024
@brunokrebs brunokrebs changed the title Missing Keys Missing fields on enum Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants