add geolocation weather example #15

michelleN · 2025-02-19T20:08:05Z

requires api token for weather site
can provide an ip addr to test with

SPIN_VARIABLE_TEST_IP_ADDR= SPIN_VARIABLE_WAQI_API_TOKEN= spin up

+ requires api token for weather site + can provide an ip addr to test with SPIN_VARIABLE_TEST_IP_ADDR=<some ip> SPIN_VARIABLE_WAQI_API_TOKEN=<some token> spin up Signed-off-by: Michelle Dhanani <[email protected]>

michelleN · 2025-02-20T20:23:02Z

samples/geolocation-weather/src/helpers.ts

@@ -0,0 +1,31 @@
+const getClientAddressFromRequest = (req: Request): string | null => {


@ThorstenHans I borrowed this from one of your js samples. It'd be great to figure out how to consolidate this logic to be used across multiple sample apps

Hmm, what are you thinking about? Sharing this across multiple apps/examples would either lead to a local or published npm package.

IMO, being repetitive here is okay, for the sake of each sample being holistic.

Or had you something different in mind @michelleN

yea, npm package was along the lines of what I was thinking but good point on being repetitive for the sake of being holistic. I think we should keep it as is.

samples/geolocation-weather/src/index.ts

karthik2804 · 2025-02-20T21:57:01Z

samples/geolocation-weather/src/index.ts

+addEventListener('fetch', async (event: FetchEvent) => {
+   let token = Variables.get("waqi_api_token");
+   if (!token) {
+     event.respondWith(new Response("Internal Server Error", {status: 500}));


It would also possibly make sense to leave a console.log here as to why the request failed to make it easier to debug. My apologies for not leaving it with the previous review.

updated 👍

Co-authored-by: Karthik Ganeshram <[email protected]> Signed-off-by: Michelle Dhanani <[email protected]>

Signed-off-by: Michelle Dhanani <[email protected]>

michelleN · 2025-04-07T14:23:02Z

@karthik2804 @ThorstenHans I think I've resolved all feedback. If ya'll could take another look, I'd appreciate it.

karthik2804 · 2025-04-09T12:47:03Z

samples/geolocation-weather/src/helpers.ts

@@ -0,0 +1,31 @@
+const getClientAddressFromRequest = (req: Request): string | null => {
+    const clientAddress = req.headers.get("spin-client-addr");


I am not sure if this issue would lead us to use a different approach here.

It's true that this header is now considered optional and that it isn't currently provided to guest apps on FwF. However, since this example is also built to run locally, this seems fine to leave in (since "true-client-ip" isn't present for spin up), noting that a suitable replacement is still pending.

vdice · 2025-07-15T10:07:53Z

samples/geolocation-weather/src/helpers.ts

+};
+
+const cleanupIpAddress = (input: string): string => {
+    const ipv4Regex = /^(\\d{1,3}\\.){3}\d{1,3}:/;


Suggested change

const ipv4Regex = /^(\\d{1,3}\\.){3}\d{1,3}:/;

const ipv4Regex = /^(\d{1,3}\.){3}\d{1,3}$/;

vdice · 2025-07-15T10:13:26Z

samples/geolocation-weather/src/helpers.ts

@@ -0,0 +1,31 @@
+const getClientAddressFromRequest = (req: Request): string | null => {
+    const clientAddress = req.headers.get("spin-client-addr");


It's true that this header is now considered optional and that it isn't currently provided to guest apps on FwF. However, since this example is also built to run locally, this seems fine to leave in (since "true-client-ip" isn't present for spin up), noting that a suitable replacement is still pending.

vdice · 2025-07-15T10:14:25Z

samples/geolocation-weather/src/index.ts

+});
+
+async function getWeather(request: Request, token: string): Promise<Response> {
+  console.log("Request received", request.headers.get("spin-client-addr"));


Although I think the instance of this header in https://github.com/fermyon/fwf-examples/pull/15/files#r2035295960 is fine and should stay, we probably should remove printing it here, since it will be null when running on FWF.

Signed-off-by: Vaughn Dice <[email protected]>

vdice · 2025-07-15T10:30:59Z

Since @michelleN is out, I took the liberty to push a commit addressing my requested changes. @karthik2804 and/or @ThorstenHans could you re-review when convenient?

karthik2804 · 2025-07-15T12:30:55Z

It looks like we already have a geo-ip example in the repo https://github.com/fermyon/fwf-examples/tree/main/samples/geo-ip. Do we want another?

michelleN force-pushed the weatherapp branch 2 times, most recently from 7d5a4c5 to a2a679b Compare February 20, 2025 20:19

michelleN marked this pull request as ready for review February 20, 2025 20:19

michelleN force-pushed the weatherapp branch from a2a679b to f6b0c6a Compare February 20, 2025 20:21

add geolocation weather example

1a9e1a2

+ requires api token for weather site + can provide an ip addr to test with SPIN_VARIABLE_TEST_IP_ADDR=<some ip> SPIN_VARIABLE_WAQI_API_TOKEN=<some token> spin up Signed-off-by: Michelle Dhanani <[email protected]>

michelleN force-pushed the weatherapp branch from f6b0c6a to 1a9e1a2 Compare February 20, 2025 20:21

michelleN commented Feb 20, 2025

View reviewed changes

michelleN requested review from ThorstenHans and karthik2804 February 20, 2025 20:23

karthik2804 reviewed Feb 20, 2025

View reviewed changes

samples/geolocation-weather/src/index.ts Show resolved Hide resolved

michelleN force-pushed the weatherapp branch from 3da16f5 to 5be7c13 Compare February 20, 2025 21:49

michelleN linked an issue Feb 20, 2025 that may be closed by this pull request

add geolocation example #13

Open

michelleN force-pushed the weatherapp branch 2 times, most recently from 6e0899c to 1114c8e Compare February 20, 2025 21:54

karthik2804 reviewed Feb 20, 2025

View reviewed changes

Update samples/geolocation-weather/src/index.ts

efa736b

Co-authored-by: Karthik Ganeshram <[email protected]> Signed-off-by: Michelle Dhanani <[email protected]>

michelleN force-pushed the weatherapp branch from 1114c8e to efa736b Compare February 20, 2025 22:01

michelleN marked this pull request as draft February 20, 2025 22:42

add attribution to CF example source

8eaf16a

Signed-off-by: Michelle Dhanani <[email protected]>

michelleN marked this pull request as ready for review February 21, 2025 18:09

karthik2804 reviewed Apr 9, 2025

View reviewed changes

vdice reviewed Jul 15, 2025

View reviewed changes

ref(samples/geolocation-weather): fix ipv4Regex, update log statement

8736058

Signed-off-by: Vaughn Dice <[email protected]>

vdice requested a review from karthik2804 July 15, 2025 10:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add geolocation weather example #15

add geolocation weather example #15

Uh oh!

michelleN commented Feb 19, 2025

Uh oh!

michelleN Feb 20, 2025

Uh oh!

ThorstenHans Feb 21, 2025

Uh oh!

michelleN Feb 21, 2025

Uh oh!

Uh oh!

karthik2804 Feb 20, 2025

Uh oh!

michelleN Feb 20, 2025

Uh oh!

michelleN commented Apr 7, 2025

Uh oh!

karthik2804 Apr 9, 2025

Uh oh!

vdice Jul 15, 2025 •

edited

Loading

Uh oh!

vdice Jul 15, 2025

Uh oh!

vdice Jul 15, 2025 •

edited

Loading

Uh oh!

vdice Jul 15, 2025

Uh oh!

vdice commented Jul 15, 2025

Uh oh!

karthik2804 commented Jul 15, 2025

Uh oh!

Uh oh!

		@@ -0,0 +1,31 @@
		const getClientAddressFromRequest = (req: Request): string \| null => {

		@@ -0,0 +1,31 @@
		const getClientAddressFromRequest = (req: Request): string \| null => {
		const clientAddress = req.headers.get("spin-client-addr");

	const ipv4Regex = /^(\\d{1,3}\\.){3}\d{1,3}:/;
	const ipv4Regex = /^(\d{1,3}\.){3}\d{1,3}$/;

add geolocation weather example #15

Are you sure you want to change the base?

add geolocation weather example #15

Uh oh!

Conversation

michelleN commented Feb 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michelleN commented Apr 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vdice Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vdice Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vdice commented Jul 15, 2025

Uh oh!

karthik2804 commented Jul 15, 2025

Uh oh!

Uh oh!

vdice Jul 15, 2025 •

edited

Loading

vdice Jul 15, 2025 •

edited

Loading