Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cloudevents example #9

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Mossaka
Copy link
Contributor

@Mossaka Mossaka commented May 2, 2022

Note:

  1. spin-sdk to upstream once the feat: Implement a wildcard in http allowed_domains to allow all domains spin#422 pr is in

Signed-off-by: Jiaxiao Zhou [email protected]

Signed-off-by: Jiaxiao Zhou <[email protected]>
Signed-off-by: Jiaxiao Zhou <[email protected]>
@Mossaka
Copy link
Contributor Author

Mossaka commented May 3, 2022

This PR also demonstrate an cloudevent exmaple using http trigger, instead of the proposed cloudevent specific trigger: fermyon/spin#394, fermyon/spin#421

Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so cool, thanks a lot, @Mossaka!

Signed-off-by: Jiaxiao Zhou <[email protected]>
@Mossaka Mossaka requested a review from radu-matei May 11, 2022 18:31
@Mossaka
Copy link
Contributor Author

Mossaka commented May 13, 2022

let's merge this in? @radu-matei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants