feat(php): allow empty object constructors if no required properties (#…

…4757)
fern-api · Sep 26, 2024 · c836480 · c836480
1 parent db3f99b
commit c836480
Show file tree

Hide file tree

Showing 75 changed files with 85 additions and 74 deletions.
diff --git a/generators/php/codegen/src/ast/DataClass.ts b/generators/php/codegen/src/ast/DataClass.ts
@@ -1,6 +1,7 @@
 import { AstNode } from "./core/AstNode";
 import { Class } from "./Class";
 import { Writer } from "./core/Writer";
+import { CodeBlock } from "./CodeBlock";
 import { Parameter } from "./Parameter";
 import { Field } from "./Field";
 import { Method } from "./Method";
@@ -61,6 +62,10 @@ export class DataClass extends AstNode {
         this.class_.write(writer);
     }
 
+    private allFieldsAreOptional(): boolean {
+        return this.class_.fields.every((field) => field.type.isOptional());
+    }
+
     private getConstructorParameters({ orderedFields }: { orderedFields: Field[] }): Parameter[] {
         return [
             new Parameter({
@@ -74,7 +79,8 @@ export class DataClass extends AstNode {
                     {
                         multiline: true
                     }
-                )
+                ),
+                initializer: this.allFieldsAreOptional() ? new CodeBlock("[]") : undefined
             })
         ];
     }

diff --git a/generators/php/sdk/versions.yml b/generators/php/sdk/versions.yml
@@ -1,3 +1,8 @@
+- version: 0.1.3
+  changelogEntry:
+    - type: feat
+      summary: >-
+        We now allow an empty constructor on types with no required properties.
 - version: 0.1.2
   changelogEntry:
     - type: feat

diff --git a/seed/php-model/audiences/src/FolderA/Service/Response.php b/seed/php-model/audiences/src/FolderA/Service/Response.php
diff --git a/seed/php-model/audiences/src/FolderB/Common/Foo.php b/seed/php-model/audiences/src/FolderB/Common/Foo.php
diff --git a/seed/php-model/circular-references-advanced/src/ImportingA.php b/seed/php-model/circular-references-advanced/src/ImportingA.php
diff --git a/seed/php-model/circular-references/src/ImportingA.php b/seed/php-model/circular-references/src/ImportingA.php
diff --git a/seed/php-model/cross-package-type-names/src/FolderA/Service/Response.php b/seed/php-model/cross-package-type-names/src/FolderA/Service/Response.php
diff --git a/seed/php-model/cross-package-type-names/src/FolderB/Common/Foo.php b/seed/php-model/cross-package-type-names/src/FolderB/Common/Foo.php
diff --git a/seed/php-model/cross-package-type-names/src/FolderD/Service/Response.php b/seed/php-model/cross-package-type-names/src/FolderD/Service/Response.php
diff --git a/seed/php-model/examples/src/Types/Tree.php b/seed/php-model/examples/src/Types/Tree.php
diff --git a/seed/php-model/exhaustive/src/Types/Object/DoubleOptional.php b/seed/php-model/exhaustive/src/Types/Object/DoubleOptional.php
diff --git a/seed/php-model/exhaustive/src/Types/Object/NestedObjectWithOptionalField.php b/seed/php-model/exhaustive/src/Types/Object/NestedObjectWithOptionalField.php
diff --git a/seed/php-model/exhaustive/src/Types/Object/ObjectWithOptionalField.php b/seed/php-model/exhaustive/src/Types/Object/ObjectWithOptionalField.php
diff --git a/seed/php-model/grpc-proto-exhaustive/src/DescribeResponse.php b/seed/php-model/grpc-proto-exhaustive/src/DescribeResponse.php
diff --git a/seed/php-model/grpc-proto-exhaustive/src/FetchResponse.php b/seed/php-model/grpc-proto-exhaustive/src/FetchResponse.php
diff --git a/seed/php-model/grpc-proto-exhaustive/src/ListElement.php b/seed/php-model/grpc-proto-exhaustive/src/ListElement.php
diff --git a/seed/php-model/grpc-proto-exhaustive/src/ListResponse.php b/seed/php-model/grpc-proto-exhaustive/src/ListResponse.php
diff --git a/seed/php-model/grpc-proto-exhaustive/src/NamespaceSummary.php b/seed/php-model/grpc-proto-exhaustive/src/NamespaceSummary.php
diff --git a/seed/php-model/grpc-proto-exhaustive/src/Pagination.php b/seed/php-model/grpc-proto-exhaustive/src/Pagination.php
diff --git a/seed/php-model/grpc-proto-exhaustive/src/QueryResponse.php b/seed/php-model/grpc-proto-exhaustive/src/QueryResponse.php
diff --git a/seed/php-model/grpc-proto-exhaustive/src/QueryResult.php b/seed/php-model/grpc-proto-exhaustive/src/QueryResult.php
diff --git a/seed/php-model/grpc-proto-exhaustive/src/UploadResponse.php b/seed/php-model/grpc-proto-exhaustive/src/UploadResponse.php
diff --git a/seed/php-model/grpc-proto-exhaustive/src/Usage.php b/seed/php-model/grpc-proto-exhaustive/src/Usage.php
diff --git a/seed/php-model/grpc-proto/src/CreateResponse.php b/seed/php-model/grpc-proto/src/CreateResponse.php
diff --git a/seed/php-model/objects-with-imports/src/Tree.php b/seed/php-model/objects-with-imports/src/Tree.php
diff --git a/seed/php-model/pagination/src/Users/UserOptionalListContainer.php b/seed/php-model/pagination/src/Users/UserOptionalListContainer.php
diff --git a/seed/php-model/pagination/src/Users/WithCursor.php b/seed/php-model/pagination/src/Users/WithCursor.php
diff --git a/seed/php-model/pagination/src/Users/WithPage.php b/seed/php-model/pagination/src/Users/WithPage.php
diff --git a/seed/php-model/trace/src/Submission/GetTraceResponsesPageRequest.php b/seed/php-model/trace/src/Submission/GetTraceResponsesPageRequest.php
diff --git a/seed/php-model/trace/src/V2/Problem/TestCaseExpects.php b/seed/php-model/trace/src/V2/Problem/TestCaseExpects.php
diff --git a/seed/php-model/trace/src/V2/V3/Problem/TestCaseExpects.php b/seed/php-model/trace/src/V2/V3/Problem/TestCaseExpects.php
diff --git a/seed/php-sdk/audiences/src/FolderA/Service/Types/Response.php b/seed/php-sdk/audiences/src/FolderA/Service/Types/Response.php
diff --git a/seed/php-sdk/audiences/src/FolderB/Common/Types/Foo.php b/seed/php-sdk/audiences/src/FolderB/Common/Types/Foo.php
diff --git a/seed/php-sdk/audiences/src/Foo/Requests/FindRequest.php b/seed/php-sdk/audiences/src/Foo/Requests/FindRequest.php
diff --git a/seed/php-sdk/circular-references-advanced/src/Types/ImportingA.php b/seed/php-sdk/circular-references-advanced/src/Types/ImportingA.php
diff --git a/seed/php-sdk/circular-references/src/Types/ImportingA.php b/seed/php-sdk/circular-references/src/Types/ImportingA.php
diff --git a/seed/php-sdk/cross-package-type-names/src/FolderA/Service/Types/Response.php b/seed/php-sdk/cross-package-type-names/src/FolderA/Service/Types/Response.php
diff --git a/seed/php-sdk/cross-package-type-names/src/FolderB/Common/Types/Foo.php b/seed/php-sdk/cross-package-type-names/src/FolderB/Common/Types/Foo.php
diff --git a/seed/php-sdk/cross-package-type-names/src/FolderD/Service/Types/Response.php b/seed/php-sdk/cross-package-type-names/src/FolderD/Service/Types/Response.php
diff --git a/seed/php-sdk/cross-package-type-names/src/Foo/Requests/FindRequest.php b/seed/php-sdk/cross-package-type-names/src/Foo/Requests/FindRequest.php
diff --git a/seed/php-sdk/examples/src/Types/Types/Tree.php b/seed/php-sdk/examples/src/Types/Types/Tree.php
diff --git a/seed/php-sdk/exhaustive/src/Types/Object/Types/DoubleOptional.php b/seed/php-sdk/exhaustive/src/Types/Object/Types/DoubleOptional.php