Skip to content

Commit

Permalink
chore(cli): remove bang operator and fix eslint warning (#4648)
Browse files Browse the repository at this point in the history
  • Loading branch information
dsinghvi authored Sep 15, 2024
1 parent 7bd1fb9 commit d6cf786
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
6 changes: 6 additions & 0 deletions packages/cli/cli/versions.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
- changelogEntry:
- summary: Remove bang operator and fix eslint warning in `compatible-ir-versions.ts`.
type: internal
irVersion: 53
version: 0.41.14-rc2

- changelogEntry:
- summary: |
Running `fern check` will now check to confirm that the generator versions you are running are compatible with your Fern CLI version.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,11 @@ async function getIrVersionForGeneratorInvocation(
dockerImage: invocation.name
});
// Again, this is to allow for offline usage, and other transient errors
if (!generatorEntity.ok) {
if (!generatorEntity.ok || generatorEntity.body == null) {
return undefined;
}
const generatorRelease = await fdr.generators.versions.getGeneratorRelease(
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
generatorEntity.body!.id,
generatorEntity.body.id,
invocation.version
);

Expand Down
2 changes: 1 addition & 1 deletion pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d6cf786

Please sign in to comment.