Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openapi): handle when custom config for filename is optional #4750

Merged
merged 4 commits into from
Sep 25, 2024
Merged

fix(openapi): handle when custom config for filename is optional #4750

merged 4 commits into from
Sep 25, 2024

Conversation

dsinghvi
Copy link
Member 

    The generator now handles `config.filename` being null so that the 
    configuration for the generator can continue to be backwards compatible.

dsinghvi
dsinghvi commented Sep 25, 2024
View reviewed changes
generators/openapi/src/customConfig.ts
@@ -3,7 +3,7 @@ import { GeneratorConfig } from "@fern-api/generator-commons";
export interface FernOpenapiCustomConfig {
format: "yaml" | "json";
customOverrides: Record<string, unknown>;
filename: string;
filename?: string;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key change

@dsinghvi dsinghvi merged commit b36fd9a into main Sep 25, 2024
47 of 48 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/type-filename-custom-config-as-optional branch September 25, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armandobelardo armandobelardo Awaiting requested review from armandobelardo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dsinghvi