feat(java): allow streaming byte requests #4765
Merged
+9,398
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcb6
commented
Sep 26, 2024
| @@ -58,4 +61,9 @@ public void upload(byte[] request, RequestOptions requestOptions) { | |||
| throw new SeedBytesException("Network error executing HTTP request", e); | |||
| } | |||
| } | |||
|
|
|||
| // Overload for backward compatibility | |||
| public void upload(byte[] request, RequestOptions requestOptions) { | |||
There was a problem hiding this comment.
thoughts on moving the direct bytes request to this?
Claude gave me these downsides but to me seems worth the cleanliness / reuse
Potential downsides of the upload overload:
Memory Usage:
The original implementation used the byte array directly.
The new overload wraps the byte array in a ByteArrayInputStream, which is then wrapped in a FileStream.
While ByteArrayInputStream is generally efficient, it does create an additional object in memory.
Performance Overhead:
There's a slight performance cost in creating the additional objects (ByteArrayInputStream and FileStream).
The streaming approach might introduce a small amount of overhead compared to sending the byte array directly, especially for small files."
dcb6
commented
Sep 26, 2024
| /** | ||
| * Represents a file stream with associated metadata for file uploads. | ||
| */ | ||
| public class FileStream { |
There was a problem hiding this comment.
we don't actually need this for bytes requests, going to delete unless anyone votes I keep it around
There was a problem hiding this comment.
awesome, may be useful to keep around to make it better for multipart (just as a uncopied utility)
dcb6
changed the title
dsinghvi
approved these changes
Sep 27, 2024
dcb6
commented
Sep 27, 2024
| - changelogEntry: | ||
| - summary: | | ||
| Bump Jackson version to latest (2.17.2) | ||
| type: chore | ||
| createdAt: '2024-09-26' | ||
| irVersion: 46 | ||
| version: 1.2.0 | ||
| version: 2.2.0 |
There was a problem hiding this comment.
this was a blunder 😅
thankfully, we never previously released a 1.2.0 and niels won't be using that until next week
I deleted this erroneous 1.2.0 tag from docker hub
…ads' of https://github.com/fern-api/fern into burke/fer-2593-assemblyai-support-streams-for-file-uploads
…ads' of https://github.com/fern-api/fern into burke/fer-2593-assemblyai-support-streams-for-file-uploads
dcb6
deleted the
burke/fer-2593-assemblyai-support-streams-for-file-uploads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.